Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webrtc/video_receive_stream.h

Issue 2789843002: Delete VieRemb class, move functionality to PacketRouter. (Closed)
Patch Set: Delete obsolete suppression for PacketRouterTest.SendTransportFeedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/vie_remb_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // See RtcpMode for description. 125 // See RtcpMode for description.
126 RtcpMode rtcp_mode = RtcpMode::kCompound; 126 RtcpMode rtcp_mode = RtcpMode::kCompound;
127 127
128 // Extended RTCP settings. 128 // Extended RTCP settings.
129 struct RtcpXr { 129 struct RtcpXr {
130 // True if RTCP Receiver Reference Time Report Block extension 130 // True if RTCP Receiver Reference Time Report Block extension
131 // (RFC 3611) should be enabled. 131 // (RFC 3611) should be enabled.
132 bool receiver_reference_time_report = false; 132 bool receiver_reference_time_report = false;
133 } rtcp_xr; 133 } rtcp_xr;
134 134
135 // TODO(nisse): This remb setting is currently set but never
136 // applied. REMB logic is now the responsibility of
137 // PacketRouter, and it will generate REMB feedback if
138 // OnReceiveBitrateChanged is used, which depends on how the
139 // estimators belonging to the ReceiveSideCongestionController
140 // are configured. Decide if this setting should be deleted, and
141 // if it needs to be replaced by a setting in PacketRouter to
142 // disable REMB feedback.
143
135 // See draft-alvestrand-rmcat-remb for information. 144 // See draft-alvestrand-rmcat-remb for information.
136 bool remb = false; 145 bool remb = false;
137 146
138 // See draft-holmer-rmcat-transport-wide-cc-extensions for details. 147 // See draft-holmer-rmcat-transport-wide-cc-extensions for details.
139 bool transport_cc = false; 148 bool transport_cc = false;
140 149
141 // See NackConfig for description. 150 // See NackConfig for description.
142 NackConfig nack; 151 NackConfig nack;
143 152
144 // See UlpfecConfig for description. 153 // See UlpfecConfig for description.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0); 218 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0);
210 } 219 }
211 220
212 protected: 221 protected:
213 virtual ~VideoReceiveStream() {} 222 virtual ~VideoReceiveStream() {}
214 }; 223 };
215 224
216 } // namespace webrtc 225 } // namespace webrtc
217 226
218 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_ 227 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/video/vie_remb_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698