Improve USB device reset logic

Improve USB device reset logic

BUG=webrtc:7203
NOTRY=True

Review-Url: https://codereview.webrtc.org/2789533002
Cr-Commit-Position: refs/heads/master@{#17656}
Committed: https://chromium.googlesource.com/external/webrtc/+/80ff00cd2bf529910d3d9d3910ad11e03bc36094

[janssonWebRTC, 2017-03-30 14:46:10]

Description was changed from

==========
Improve USB device reset logic

BUG=
==========

to

==========
Improve USB device reset logic

BUG=webrtc:7203
==========

[janssonWebRTC, 2017-03-30 14:47:29]

Hi,

Could you PTAL? I've now added support for two different USB driver id strings.
Will look into writing tests for this script in a follow up CL.

[janssonWebRTC, 2017-03-30 14:47:42]

jansson@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-03-30 15:52:42]

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
File webrtc/tools/run_video_analysis.py (right):

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis.py:161: def
FindUsbPortForV4lDevices(ref_video_device, test_video_device):
FindUsbPortForV4lDevices is a great candidate for a simple unit test. Can you
please write one?

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis.py:177: # usb device port mappings and it's the
same in all usbN folders.
Maybe mention something about (at least on Ubuntu Trusty) since I imagine other
distros may have other layouts.

[janssonWebRTC, 2017-03-31 11:55:39]

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
File webrtc/tools/run_video_analysis.py (right):

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis.py:161: def
FindUsbPortForV4lDevices(ref_video_device, test_video_device):
On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> FindUsbPortForV4lDevices is a great candidate for a simple unit test. Can you
> please write one?

Done.

https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis.py:177: # usb device port mappings and it's the
same in all usbN folders.
On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> Maybe mention something about (at least on Ubuntu Trusty) since I imagine
other
> distros may have other layouts.

Done.

[janssonWebRTC, 2017-03-31 13:48:35]

On 2017/03/31 11:55:39, janssonWebRTC wrote:
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> File webrtc/tools/run_video_analysis.py (right):
> 
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> webrtc/tools/run_video_analysis.py:161: def
> FindUsbPortForV4lDevices(ref_video_device, test_video_device):
> On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> > FindUsbPortForV4lDevices is a great candidate for a simple unit test. Can
you
> > please write one?
> 
> Done.
> 
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> webrtc/tools/run_video_analysis.py:177: # usb device port mappings and it's
the
> same in all usbN folders.
> On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> > Maybe mention something about (at least on Ubuntu Trusty) since I imagine
> other
> > distros may have other layouts.
> 
> Done.

Ow I forgot to add the test to the build file, do I add it sources in the
tools_unittest target or is that for tests to be compiled only?

[janssonWebRTC, 2017-04-04 12:52:54]

On 2017/03/31 13:48:35, janssonWebRTC wrote:
> On 2017/03/31 11:55:39, janssonWebRTC wrote:
> >
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> > File webrtc/tools/run_video_analysis.py (right):
> > 
> >
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> > webrtc/tools/run_video_analysis.py:161: def
> > FindUsbPortForV4lDevices(ref_video_device, test_video_device):
> > On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> > > FindUsbPortForV4lDevices is a great candidate for a simple unit test. Can
> you
> > > please write one?
> > 
> > Done.
> > 
> >
>
https://codereview.webrtc.org/2789533002/diff/20001/webrtc/tools/run_video_an...
> > webrtc/tools/run_video_analysis.py:177: # usb device port mappings and it's
> the
> > same in all usbN folders.
> > On 2017/03/30 15:52:42, kjellander_webrtc wrote:
> > > Maybe mention something about (at least on Ubuntu Trusty) since I imagine
> > other
> > > distros may have other layouts.
> > 
> > Done.
> 
> Ow I forgot to add the test to the build file, do I add it sources in the
> tools_unittest target or is that for tests to be compiled only?

Ping ;)

[kjellander_webrtc, 2017-04-04 14:44:23]

You need to add the dir to
https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#472 in
order to get the test to be run on PRESUBMIT.

No need to add it to any GN target.

https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
File webrtc/tools/run_video_analysis_unittest.py (right):

https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis_unittest.py:1: #!/usr/bin/env python
Rename this file to run_video_analysis_test.py

It's needed to match
https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#482

https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
webrtc/tools/run_video_analysis_unittest.py:12: import glob
sort "import glob" before "import unittest"

[janssonWebRTC, 2017-04-10 14:37:39]

On 2017/04/04 14:44:23, kjellander_webrtc wrote:
> You need to add the dir to
> https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#472 in
> order to get the test to be run on PRESUBMIT.
> 
> No need to add it to any GN target.
> 
Done

>
https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
> File webrtc/tools/run_video_analysis_unittest.py (right):
> 
>
https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
> webrtc/tools/run_video_analysis_unittest.py:1: #!/usr/bin/env python
> Rename this file to run_video_analysis_test.py
> 
> It's needed to match
> https://chromium.googlesource.com/external/webrtc/+/master/PRESUBMIT.py#482
> 
> 
Done

https://codereview.webrtc.org/2789533002/diff/40001/webrtc/tools/run_video_an...
> webrtc/tools/run_video_analysis_unittest.py:12: import glob
> sort "import glob" before "import unittest"
Done

I also removed the run_ prefix of the scripts

[kjellander_webrtc, 2017-04-11 14:33:34]

lgtm
don't forget NOTRY=True

[janssonWebRTC, 2017-04-11 14:37:45]

Description was changed from

==========
Improve USB device reset logic

BUG=webrtc:7203
==========

to

==========
Improve USB device reset logic

BUG=webrtc:7203
NOTRY=True
==========

[janssonWebRTC, 2017-04-11 14:37:51]

The CQ bit was checked by jansson@webrtc.org

[commit-bot: I haz the power, 2017-04-11 14:37:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 14:40:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491921471318830,
"parent_rev": "b213a16b2801a0ebdf0e5497d96b1feaff9fe9e6", "commit_rev":
"80ff00cd2bf529910d3d9d3910ad11e03bc36094"}

[commit-bot: I haz the power, 2017-04-11 14:40:30]

Description was changed from

==========
Improve USB device reset logic

BUG=webrtc:7203
NOTRY=True
==========

to

==========
Improve USB device reset logic

BUG=webrtc:7203
NOTRY=True

Review-Url: https://codereview.webrtc.org/2789533002
Cr-Commit-Position: refs/heads/master@{#17656}
Committed:
https://chromium.googlesource.com/external/webrtc/+/80ff00cd2bf529910d3d9d391...
==========

[commit-bot: I haz the power, 2017-04-11 14:40:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/80ff00cd2bf529910d3d9d391...