Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2789483002:
Make sure we observe enough frames before scaling. (Closed)
|
Created:
3 years, 8 months ago by kthelgason Modified:
3 years, 8 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, magjed_webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMake sure we observe enough frames before scaling.
If the encoder takes a long time to start up and emit frames the polling
interval of the quality scaler would get out of sync. This causes it to
sometimes make scaling decisions based on only a handful of frames.
This CL ensures that we have observed some minimum number of frames
before deciding to scale up or down.
BUG=b/36734056
Review-Url: https://codereview.webrtc.org/2789483002
Cr-Commit-Position: refs/heads/master@{#17523}
Committed: https://chromium.googlesource.com/external/webrtc/+/55a01354841fa9ab2bcbb4623c1176dfc560fbdc
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 2
Patch Set 3 : Add test for new behaviour #
Messages
Total messages: 26 (18 generated)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15583)
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
kthelgason@webrtc.org changed reviewers: + sprang@webrtc.org
Erik, PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/22936)
magjed@webrtc.org changed reviewers: + magjed@webrtc.org
https://codereview.webrtc.org/2789483002/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/2789483002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:151: Can you add a test targeting the specific issue, i.e. that we don't downscale based on too few frames?
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2789483002/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/utility/quality_scaler_unittest.cc (right): https://codereview.webrtc.org/2789483002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/utility/quality_scaler_unittest.cc:151: On 2017/03/30 11:15:02, magjed_webrtc wrote: > Can you add a test targeting the specific issue, i.e. that we don't downscale > based on too few frames? Good point, done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
kthelgason@webrtc.org changed reviewers: + henrika@webrtc.org - sprang@webrtc.org
+Henrik for owner approval.
lgtm
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491296927892120,
"parent_rev": "751c9dc904f51910766e6050baad97a91312b406", "commit_rev":
"55a01354841fa9ab2bcbb4623c1176dfc560fbdc"}
Message was sent while issue was closed.
Description was changed from ========== Make sure we observe enough frames before scaling. If the encoder takes a long time to start up and emit frames the polling interval of the quality scaler would get out of sync. This causes it to sometimes make scaling decisions based on only a handful of frames. This CL ensures that we have observed some minimum number of frames before deciding to scale up or down. BUG=b/36734056 ========== to ========== Make sure we observe enough frames before scaling. If the encoder takes a long time to start up and emit frames the polling interval of the quality scaler would get out of sync. This causes it to sometimes make scaling decisions based on only a handful of frames. This CL ensures that we have observed some minimum number of frames before deciding to scale up or down. BUG=b/36734056 Review-Url: https://codereview.webrtc.org/2789483002 Cr-Commit-Position: refs/heads/master@{#17523} Committed: https://chromium.googlesource.com/external/webrtc/+/55a01354841fa9ab2bcbb4623... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/55a01354841fa9ab2bcbb4623... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
