Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2789283002:
vp9: Enable vp9 denoiser by default in standalone webrtc. (Closed)
Descriptionvp9: Enable vp9 denoiser by default in standalone webrtc.
BUG=None
Review-Url: https://codereview.webrtc.org/2789283002
Cr-Commit-Position: refs/heads/master@{#18450}
Committed: https://chromium.googlesource.com/external/webrtc/+/6bf57e346794950aec9a789ea906e3d14ba9a6e2
Patch Set 1 #Patch Set 2 : Fix some compile issues. #Patch Set 3 : Remove enumerate type. #Patch Set 4 : vp9: Enable vp9 denoiser by default in standalone webrtc. #Patch Set 5 : vp9: Enable vp9 denoiser by default in standalone webrtc. #
Total comments: 2
Patch Set 6 : address comments. #Messages
Total messages: 33 (24 generated)
Description was changed from ========== vp9: Enable vp9 denoiser by default in standalone webrtc. BUG=None ========== to ========== vp9: Enable vp9 denoiser by default in standalone webrtc. BUG=None ==========
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...) win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by jianj@google.com
marpan@google.com changed reviewers: + brandtr@webrtc.org, marpan@webrtc.org, mflodman@webrtc.org
lgtm Will be interesting to see if/how the perf tests change!
The CQ bit was checked by jianj@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16175)
Feel free to land this. That will enable the denoiser in the perf tests. Also, please add bug 7412 to the description. https://codereview.webrtc.org/2789283002/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/2789283002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:458: // Turn off the denoiser on ARM since optimization is pending. Nit: "Do not enable the denoiser..." (Since you are actively not turning it on, not actively turning it off.)
mflodman@google.com changed reviewers: + mflodman@google.com
lgtm
https://codereview.webrtc.org/2789283002/diff/80001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc (right): https://codereview.webrtc.org/2789283002/diff/80001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:458: // Turn off the denoiser on ARM since optimization is pending. On 2017/05/29 07:14:35, brandtr wrote: > Nit: "Do not enable the denoiser..." > > (Since you are actively not turning it on, not actively turning it off.) Done.
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jianj@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org, mflodman@google.com Link to the patchset: https://codereview.webrtc.org/2789283002/#ps100001 (title: "address comments.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496695314948310,
"parent_rev": "b72fd747e78a7f0cb1719a71c8df0041852967d5", "commit_rev":
"6bf57e346794950aec9a789ea906e3d14ba9a6e2"}
Message was sent while issue was closed.
Description was changed from ========== vp9: Enable vp9 denoiser by default in standalone webrtc. BUG=None ========== to ========== vp9: Enable vp9 denoiser by default in standalone webrtc. BUG=None Review-Url: https://codereview.webrtc.org/2789283002 Cr-Commit-Position: refs/heads/master@{#18450} Committed: https://chromium.googlesource.com/external/webrtc/+/6bf57e346794950aec9a789ea... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/external/webrtc/+/6bf57e346794950aec9a789ea... |
