Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2788683002: Send data from mixer to APM limiter more often. (Closed)

Created:
3 years, 8 months ago by niklas.enbom
Modified:
3 years, 8 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, aleloi, hlundin-webrtc
Target Ref:
refs/branch-heads/58
Project:
webrtc
Visibility:
Public.

Description

Send data from mixer to APM limiter more often. Before this change, the APM limiter used in FrameCombiner (a sub-component of AudioMixer) only gets to process the data when the number of non-muted streams is >1. If this number varies between <=1 and >1, the limiter's view of the data will have gaps during the periods with <= 1 active stream. This leads to discontinuities in the applied gain. These discontinuities cause clicks in the output audio. This change activates APM limiter processing based on the number of audio streams, independently of their mutedness status. BUG=chromium:695993 TBR=aleloi@webrtc.org Review-Url: https://codereview.webrtc.org/2776113002 Cr-Original-Commit-Position: refs/heads/master@{#17442} Review-Url: https://codereview.webrtc.org/2788683002 . Cr-Commit-Position: refs/branch-heads/58@{#11} Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937} Committed: https://chromium.googlesource.com/external/webrtc/+/c4a49c0af18b5014bb4439c2e2c70bf5c76ea099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -85 lines) Patch
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_mixer/frame_combiner.h View 1 chunk +5 lines, -14 lines 0 comments Download
M webrtc/modules/audio_mixer/frame_combiner.cc View 5 chunks +101 lines, -63 lines 0 comments Download
M webrtc/modules/audio_mixer/frame_combiner_unittest.cc View 7 chunks +77 lines, -7 lines 0 comments Download
A webrtc/modules/audio_mixer/gain_change_calculator.h View 1 chunk +38 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/gain_change_calculator.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/sine_wave_generator.h View 1 chunk +38 lines, -0 lines 0 comments Download
A webrtc/modules/audio_mixer/sine_wave_generator.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
niklas.enbom
3 years, 8 months ago (2017-03-30 16:06:21 UTC) #3
niklas.enbom
3 years, 8 months ago (2017-03-30 16:06:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4a49c0af18b5014bb4439c2e2c70bf5c76ea099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698