Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2787453004: gtest-parallel: Concatenate the log files in the passed, failed and interrupted dirs. (Closed)

Created:
3 years, 8 months ago by ehmaldonado_webrtc
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

gtest-parallel: Concatenate the log files in the passed, failed and interrupted dirs. BUG=webrtc:7391 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2787453004 Cr-Commit-Position: refs/heads/master@{#17468} Committed: https://chromium.googlesource.com/external/webrtc/+/031846393c7d53753c3b9a04b5d5ae2aac1f94bc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -60 lines) Patch
M tools-webrtc/gtest-parallel-wrapper.py View 1 1 chunk +85 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
ehmaldonado_webrtc
PTAL :)
3 years, 8 months ago (2017-03-29 17:16:46 UTC) #2
kjellander_webrtc
lgtm with nits fixed https://codereview.webrtc.org/2787453004/diff/20001/tools-webrtc/gtest-parallel-wrapper.py File tools-webrtc/gtest-parallel-wrapper.py (right): https://codereview.webrtc.org/2787453004/diff/20001/tools-webrtc/gtest-parallel-wrapper.py#newcode67 tools-webrtc/gtest-parallel-wrapper.py:67: # where only tests in ...
3 years, 8 months ago (2017-03-29 21:13:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2787453004/40001
3 years, 8 months ago (2017-03-30 10:30:40 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 10:33:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/031846393c7d53753c3b9a04b...

Powered by Google App Engine
This is Rietveld 408576698