Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2787283003: Add thread check to PacketRouter::SendFeedback, which is called on the pacer thread. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add thread check to PacketRouter::SendFeedback, which is called on the pacer thread. Lock is still needed, since other threads may call the methods which modify the lists. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/pacing/packet_router.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
nisse-webrtc
PTAL. Call thread setup includes module_process_thread_->RegisterModule(&receive_side_cc_, RTC_FROM_HERE); pacer_thread_->RegisterModule( receive_side_cc_.GetRemoteBitrateEstimator(true), RTC_FROM_HERE); The latter call is the ...
3 years, 8 months ago (2017-03-31 08:53:53 UTC) #4
stefan-webrtc
lgtm
3 years, 8 months ago (2017-03-31 13:53:00 UTC) #7
nisse-webrtc
3 years, 8 months ago (2017-03-31 13:59:17 UTC) #8
On 2017/03/31 13:53:00, stefan-webrtc wrote:
> lgtm

Thanks, but already landed as part of the larger cl
https://codereview.webrtc.org/2774623006/ ;-)

I'm closing this one.

Powered by Google App Engine
This is Rietveld 408576698