Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: webrtc/modules/pacing/packet_router.cc

Issue 2787283003: Add thread check to PacketRouter::SendFeedback, which is called on the pacer thread. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // operation was successful - otherwise we need to retry. Saving the 99 // operation was successful - otherwise we need to retry. Saving the
100 // return value saves us a load on retry. 100 // return value saves us a load on retry.
101 prev_seq = rtc::AtomicOps::CompareAndSwap(&transport_seq_, desired_prev_seq, 101 prev_seq = rtc::AtomicOps::CompareAndSwap(&transport_seq_, desired_prev_seq,
102 new_seq); 102 new_seq);
103 } while (prev_seq != desired_prev_seq); 103 } while (prev_seq != desired_prev_seq);
104 104
105 return new_seq; 105 return new_seq;
106 } 106 }
107 107
108 bool PacketRouter::SendFeedback(rtcp::TransportFeedback* packet) { 108 bool PacketRouter::SendFeedback(rtcp::TransportFeedback* packet) {
109 RTC_DCHECK(pacer_thread_checker_.CalledOnValidThread());
109 rtc::CritScope cs(&modules_crit_); 110 rtc::CritScope cs(&modules_crit_);
110 for (auto* rtp_module : rtp_modules_) { 111 for (auto* rtp_module : rtp_modules_) {
111 packet->SetSenderSsrc(rtp_module->SSRC()); 112 packet->SetSenderSsrc(rtp_module->SSRC());
112 if (rtp_module->SendFeedbackPacket(*packet)) 113 if (rtp_module->SendFeedbackPacket(*packet))
113 return true; 114 return true;
114 } 115 }
115 return false; 116 return false;
116 } 117 }
117 118
118 } // namespace webrtc 119 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698