Correction of the AEC3 underrun behavior and minor other corrections

Correction of the AEC3 underrun behavior and minor other corrections

This CL corrects the behavior during buffer underruns.

Furthermore, it increases the tolerance for API call jitter, and
removes the minimum value for the comfort noise.


BUG=webrtc:6018
Review-Url: https://codereview.webrtc.org/2787123003
Cr-Commit-Position: refs/heads/master@{#17576}
Committed: https://chromium.googlesource.com/external/webrtc/+/4b572d048a885d56bf2411e2ddabc90e3991b338

[peah-webrtc, 2017-04-06 13:33:32]

Description was changed from

==========
AEC3 Buffering fixes

BUG=
==========

to

==========
Correction of the AEC3 underrun behavior and minor other corrections

This CL corrects the behavior during buffer underruns.

Furthermore, it increases the tolerance for API call jitter, and
removes the minimum value for the comfort noise.


BUG=webrtc:6018
==========

[peah-webrtc, 2017-04-06 13:33:51]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-04-06 13:33:58]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2017-04-06 13:39:07]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[peah-webrtc, 2017-04-06 13:39:08]

Hi,
I have another update to the AEC3. It is much smaller than before, and I have
added comments explaining each change.

Would you be able to have a look?

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/aec3_common.h (right):

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/aec3_common.h:66: constexpr size_t
kMaxApiCallsJitterBlocks = 20;
This change adds headroom for larger API jitter which was seen on some
platforms.

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/block_processor.cc (left):

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/block_processor.cc:104: } else {
Before this change, the AEC leaked echo for one block each time there was an
overrun. That is corrected by this change.

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/comfort_noise_generator.cc (left):

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/comfort_noise_generator.cc:191: // Limit
the noise to a floor of -96 dBFS.
This limit caused the comfort noise in very silent recordings to be too high.
Removing it solves that.

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/render_delay_buffer.cc (right):

https://codereview.webrtc.org/2787123003/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/render_delay_buffer.cc:129: for (auto& c :
buffer_) {
After a buffer delay reset (due to a too long buffer delay for instance
occurring during clockdrift), the missing zeroing of the buffer caused the
filter to diverge initially. Setting the buffer to zero solves that.

[ivoc, 2017-04-06 14:25:35]

LGTM!

[aleloi, 2017-04-06 14:46:29]

aleloi@webrtc.org changed reviewers:
+ aleloi@webrtc.org

[aleloi, 2017-04-06 14:46:30]

lgtm

[peah-webrtc, 2017-04-06 23:11:49]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-04-06 23:11:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org,
aleloi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2787123003/#ps60001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-04-06 23:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 23:33:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491520309308030,
"parent_rev": "86afe9d6618a57e4817e6f9261042e785b7ff0c8", "commit_rev":
"4b572d048a885d56bf2411e2ddabc90e3991b338"}

[commit-bot: I haz the power, 2017-04-06 23:33:09]

Description was changed from

==========
Correction of the AEC3 underrun behavior and minor other corrections

This CL corrects the behavior during buffer underruns.

Furthermore, it increases the tolerance for API call jitter, and
removes the minimum value for the comfort noise.


BUG=webrtc:6018
==========

to

==========
Correction of the AEC3 underrun behavior and minor other corrections

This CL corrects the behavior during buffer underruns.

Furthermore, it increases the tolerance for API call jitter, and
removes the minimum value for the comfort noise.


BUG=webrtc:6018

Review-Url: https://codereview.webrtc.org/2787123003
Cr-Commit-Position: refs/heads/master@{#17576}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4b572d048a885d56bf2411e2d...
==========

[commit-bot: I haz the power, 2017-04-06 23:33:10]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/4b572d048a885d56bf2411e2d...