Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2786913003: Revert of Enable the bayesian bitrate estimator by default. (Closed)

Created:
3 years, 8 months ago by lliuu
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable the bayesian bitrate estimator by default. (patchset #5 id:80001 of https://codereview.webrtc.org/2749803002/ ) Reason for revert: Looks like this has caused multiple Android webrtc perf build bot failures in RampUpTest.UpDownUpTransportSequenceNumberRtx Original issue's description: > Enable the bayesian bitrate estimator by default. > > BUG=webrtc:6566, webrtc:7415 > > Review-Url: https://codereview.webrtc.org/2749803002 > Cr-Commit-Position: refs/heads/master@{#17475} > Committed: https://chromium.googlesource.com/external/webrtc/+/c53a17f28e55c99dca7a2a47f09790af466e9334 TBR=terelius@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6566, webrtc:7415 Review-Url: https://codereview.webrtc.org/2786913003 Cr-Commit-Position: refs/heads/master@{#17476} Committed: https://chromium.googlesource.com/external/webrtc/+/7a3615b6b394bfe12a0ab528dee0dd33620e0e63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -20 lines) Patch
M webrtc/call/rampup_tests.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDAppDelegate.m View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 2 chunks +16 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 7 chunks +45 lines, -14 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lliuu
Created Revert of Enable the bayesian bitrate estimator by default.
3 years, 8 months ago (2017-03-30 17:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2786913003/1
3 years, 8 months ago (2017-03-30 17:36:50 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:36:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7a3615b6b394bfe12a0ab528d...

Powered by Google App Engine
This is Rietveld 408576698