Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2786603004:
Make WebRtcAudioEffects and its create method public. (Closed)
DescriptionMake WebRtcAudioEffects and its create method public.
This allows it to be reused with Android AudioRecords created outside
WebRtcAudioRecord. WebRtcAudioEffects provides useful methods for enabling
hardware effects (such as echo cancellation) only on appropriate devices. It
also allows some control of these effects through WebRtcAudioUtils.
BUG=webrtc:7448
Review-Url: https://codereview.webrtc.org/2786603004
Cr-Commit-Position: refs/heads/master@{#18053}
Committed: https://chromium.googlesource.com/external/webrtc/+/90bdb3d138eaa10627c156b5487ffb4397f48359
Patch Set 1 #Patch Set 2 #Patch Set 3 : Sync/rebase on top of main branch #Messages
Total messages: 25 (21 generated)
The CQ bit was checked by mellem@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15565)
Description was changed from ========== Make WebRtcAudioEffects and its create method public. This allows it to be reused with Android AudioRecords created outside WebRtcAudioRecord. WebRtcAudioEffects provides useful methods for enabling hardware effects (such as echo cancellation) only on appropriate devices. It also allows some control of these effects through WebRtcAudioUtils. BUG= ========== to ========== Make WebRtcAudioEffects and its create method public. This allows it to be reused with Android AudioRecords created outside WebRtcAudioRecord. WebRtcAudioEffects provides useful methods for enabling hardware effects (such as echo cancellation) only on appropriate devices. It also allows some control of these effects through WebRtcAudioUtils. BUG=webrtc:7448 ==========
The CQ bit was checked by mellem@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by mellem@webrtc.org
The CQ bit was unchecked by mellem@webrtc.org
The CQ bit was checked by mellem@webrtc.org
The CQ bit was unchecked by mellem@webrtc.org
mellem@webrtc.org changed reviewers: + henrika@webrtc.org
henrika@webrtc.org changed reviewers: + solenberg@webrtc.org
LGTM
lgtm
The CQ bit was checked by mellem@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mellem@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org, henrika@webrtc.org Link to the patchset: https://codereview.webrtc.org/2786603004/#ps40001 (title: "Sync/rebase on top of main branch")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494263912138570,
"parent_rev": "b8b1417ac1adb3834980f5102be6ea5299429922", "commit_rev":
"90bdb3d138eaa10627c156b5487ffb4397f48359"}
Message was sent while issue was closed.
Description was changed from ========== Make WebRtcAudioEffects and its create method public. This allows it to be reused with Android AudioRecords created outside WebRtcAudioRecord. WebRtcAudioEffects provides useful methods for enabling hardware effects (such as echo cancellation) only on appropriate devices. It also allows some control of these effects through WebRtcAudioUtils. BUG=webrtc:7448 ========== to ========== Make WebRtcAudioEffects and its create method public. This allows it to be reused with Android AudioRecords created outside WebRtcAudioRecord. WebRtcAudioEffects provides useful methods for enabling hardware effects (such as echo cancellation) only on appropriate devices. It also allows some control of these effects through WebRtcAudioUtils. BUG=webrtc:7448 Review-Url: https://codereview.webrtc.org/2786603004 Cr-Commit-Position: refs/heads/master@{#18053} Committed: https://chromium.googlesource.com/external/webrtc/+/90bdb3d138eaa10627c156b54... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/90bdb3d138eaa10627c156b54... |
