Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2786603002: We need to specify the decoder map explicitly nowadays (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

We need to specify the decoder map explicitly nowadays (Since this CL landed: https://codereview.webrtc.org/2774833003/.) Without this fix, low_bandwidth_audio_test breaks on the perf bots. BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2786603002 Cr-Commit-Position: refs/heads/master@{#17440} Committed: https://chromium.googlesource.com/external/webrtc/+/a1ab8bafe7fd8fd7a89faa0fd1d519bba5305285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/test/call_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-03-29 09:46:57 UTC) #8
oprypin_webrtc
Thanks for the fix. LGTM
3 years, 8 months ago (2017-03-29 10:23:01 UTC) #9
kjellander_webrtc
lgtm Annoying Win Clang Debug failures. I retried those bots. I'll land a landmine CL ...
3 years, 8 months ago (2017-03-29 10:43:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2786603002/1
3 years, 8 months ago (2017-03-29 10:45:59 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 11:06:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a1ab8bafe7fd8fd7a89faa0fd...

Powered by Google App Engine
This is Rietveld 408576698