Add histogram stats for number of cpu/quality adapt changes per minute for sent video streams:

Add histogram stats for number of cpu/quality adapt changes per minute for sent video streams:

- "WebRTC.Video.AdaptChangesPerMinute.Cpu"
- "WebRTC.Video.AdaptChangesPerMinute.Quality"

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2786593003
Cr-Commit-Position: refs/heads/master@{#17535}
Committed: https://chromium.googlesource.com/external/webrtc/+/6eca98b7e556a51fe846d623df4ed1442006c8b6

[åsapersson, 2017-03-29 14:01:07]

Patchset #1 (id:1) has been deleted

[åsapersson, 2017-03-29 14:04:26]

Patchset #1 (id:20001) has been deleted

[åsapersson, 2017-03-29 14:35:09]

Patchset #1 (id:40001) has been deleted

[åsapersson, 2017-03-29 14:35:41]

Description was changed from

==========
Add histogram stats for number of cpu/quality adapt changes per minute for sent
video streams:

- "WebRTC.Video.QualityAdaptChangesPerMinute"
- "WebRTC.Video.CpuAdaptChangesPerMinute"

BUG=webrtc:6634
==========

to

==========
Add histogram stats for number of cpu/quality adapt changes per minute for sent
video streams:

- "WebRTC.Video.AdaptChangesPerMinute.Cpu"
- "WebRTC.Video.AdaptChangesPerMinute.Quality"

BUG=webrtc:6634
==========

[åsapersson, 2017-03-29 14:35:41]

asapersson@webrtc.org changed reviewers:
+ sprang@webrtc.org

[åsapersson, 2017-03-31 12:42:07]

asapersson@webrtc.org changed reviewers:
- sprang@webrtc.org

[åsapersson, 2017-04-03 09:59:38]

Patchset #4 (id:120001) has been deleted

[åsapersson, 2017-04-03 10:11:34]

Patchset #5 (id:160001) has been deleted

[åsapersson, 2017-04-03 10:14:52]

Patchset #5 (id:180001) has been deleted

[åsapersson, 2017-04-03 11:02:14]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[åsapersson, 2017-04-03 12:02:09]

Patchset #5 (id:200001) has been deleted

[åsapersson, 2017-04-03 12:02:35]

Patchset #2 (id:80001) has been deleted

[brandtr, 2017-04-04 11:24:21]

lgtm, with some naming questions :)

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.cc:698: void
SendStatisticsProxy::SetCpuScalingStats(int cpu_restricted_resolutions) {
To be consistent with the method below, maybe name as |num_cpu_downscales|?

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.cc:728: TRACE_EVENT_INSTANT0("webrtc_stats",
"WebRTC.Video.AdaptationChanges");
Should this trace name be updated?

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.h:155: SampleCounter vp8;   // QP range:
0-127
Unrelated nit: add period to these three comment lines.

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:481:
fake_clock_.AdvanceTimeMilliseconds(10000);
Should this be metrics::kMinRunTimeInSeconds * 1000?

[åsapersson, 2017-04-04 14:28:52]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 14:29:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[åsapersson, 2017-04-04 14:30:52]

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.cc:698: void
SendStatisticsProxy::SetCpuScalingStats(int cpu_restricted_resolutions) {
On 2017/04/04 11:24:21, brandtr wrote:
> To be consistent with the method below, maybe name as |num_cpu_downscales|?

Done.

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.cc:728: TRACE_EVENT_INSTANT0("webrtc_stats",
"WebRTC.Video.AdaptationChanges");
On 2017/04/04 11:24:21, brandtr wrote:
> Should this trace name be updated?

Done.

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.h:155: SampleCounter vp8;   // QP range:
0-127
On 2017/04/04 11:24:21, brandtr wrote:
> Unrelated nit: add period to these three comment lines.

Done.

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2786593003/diff/220001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:481:
fake_clock_.AdvanceTimeMilliseconds(10000);
On 2017/04/04 11:24:21, brandtr wrote:
> Should this be metrics::kMinRunTimeInSeconds * 1000?

Not testing specifically for that in this test (min runtime will have passed
when the test ends and stats will be reported).

[commit-bot: I haz the power, 2017-04-04 14:51:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 14:51:19]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-04-05 06:38:15]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-04-05 06:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2786593003/#ps260001 (title:
"address comments")

[commit-bot: I haz the power, 2017-04-05 06:38:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-05 06:40:50]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1491374295593610,
"parent_rev": "d48dbda43453dc9ff73f07eaf9f1b852b724568f", "commit_rev":
"6eca98b7e556a51fe846d623df4ed1442006c8b6"}

[commit-bot: I haz the power, 2017-04-05 06:40:54]

Description was changed from

==========
Add histogram stats for number of cpu/quality adapt changes per minute for sent
video streams:

- "WebRTC.Video.AdaptChangesPerMinute.Cpu"
- "WebRTC.Video.AdaptChangesPerMinute.Quality"

BUG=webrtc:6634
==========

to

==========
Add histogram stats for number of cpu/quality adapt changes per minute for sent
video streams:

- "WebRTC.Video.AdaptChangesPerMinute.Cpu"
- "WebRTC.Video.AdaptChangesPerMinute.Quality"

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2786593003
Cr-Commit-Position: refs/heads/master@{#17535}
Committed:
https://chromium.googlesource.com/external/webrtc/+/6eca98b7e556a51fe846d623d...
==========

[commit-bot: I haz the power, 2017-04-05 06:40:55]

Committed patchset #6 (id:260001) as
https://chromium.googlesource.com/external/webrtc/+/6eca98b7e556a51fe846d623d...