Add loss-based BWE experiment which allows us to try different parameters.

Add loss-based BWE experiment which allows us to try different parameters.

BUG=webrtc:5839
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2786353002 .
Cr-Commit-Position: refs/heads/master@{#17490}
Committed: https://chromium.googlesource.com/external/webrtc/+/9c79ed9224b37a09b9c941147f1ab10b40c39d58

[stefan-webrtc, 2017-03-31 08:02:02]

stefan@webrtc.org changed reviewers:
+ terelius@webrtc.org

[terelius, 2017-03-31 08:24:33]

lgtm % comment

https://codereview.webrtc.org/2786353002/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc
(right):

https://codereview.webrtc.org/2786353002/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc:87:
RTC_CHECK_GE(*bitrate_threshold_kbps, 0)
I'd like to also check that bitrate_threshold_kbps < INT_MAX / 1000 to make sure
we don't overflow below.

[stefan-webrtc, 2017-03-31 13:51:05]

https://codereview.webrtc.org/2786353002/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc
(right):

https://codereview.webrtc.org/2786353002/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc:87:
RTC_CHECK_GE(*bitrate_threshold_kbps, 0)
On 2017/03/31 08:24:33, terelius wrote:
> I'd like to also check that bitrate_threshold_kbps < INT_MAX / 1000 to make
sure
> we don't overflow below.

Done.

[stefan-webrtc, 2017-03-31 13:53:32]

Description was changed from

==========
Add loss-based BWE experiment which allows us to try different parameters.

BUG=webrtc:5839
==========

to

==========
Add loss-based BWE experiment which allows us to try different parameters.

BUG=webrtc:5839
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2786353002 .
Cr-Commit-Position: refs/heads/master@{#17490}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9c79ed9224b37a09b9c941147...
==========

[stefan-webrtc, 2017-03-31 13:53:33]

Committed patchset #2 (id:20001) manually as
9c79ed9224b37a09b9c941147f1ab10b40c39d58 (presubmit successful).