Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2785673002: Remove more CriticalSectionWrappers. (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove more CriticalSectionWrappers. BUG=webrtc:7035 Review-Url: https://codereview.webrtc.org/2785673002 Cr-Commit-Position: refs/heads/master@{#17465} Committed: https://chromium.googlesource.com/external/webrtc/+/6bfe49c00a1908e3bf05f36c7d6b420817f6304f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -229 lines) Patch
M webrtc/modules/audio_conference_mixer/source/time_scheduler.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/time_scheduler.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 9 chunks +7 lines, -16 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 7 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 5 chunks +3 lines, -10 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc View 15 chunks +21 lines, -23 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc View 15 chunks +20 lines, -22 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_alsa_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_mixer_manager_alsa_linux.cc View 13 chunks +13 lines, -20 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.h View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 38 chunks +36 lines, -41 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/media_file/media_file_impl.cc View 21 chunks +20 lines, -26 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 13 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
kthelgason
If you have nothing better to do!
3 years, 8 months ago (2017-03-29 12:36:50 UTC) #6
tommi
wohoo! lgtm!
3 years, 8 months ago (2017-03-29 13:10:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785673002/1
3 years, 8 months ago (2017-03-29 13:31:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux32_arm_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux32_arm_rel/builds/4) linux_arm64_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 13:34:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785673002/1
3 years, 8 months ago (2017-03-29 13:50:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/9) linux_arm64_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 13:55:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785673002/1
3 years, 8 months ago (2017-03-30 08:09:44 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 08:14:49 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6bfe49c00a1908e3bf05f36c7...

Powered by Google App Engine
This is Rietveld 408576698