Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2785653002: Use Chromium's mirror of github for gtest-parallel. (Closed)

Created:
3 years, 8 months ago by ehmaldonado_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use Chromium's mirror of github for gtest-parallel. - Move gtest-parallel-wrapper.py to tools-webrtc. - Update mb.py and mb_unittest.py BUG=webrtc:7391 NOTRY=True R=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2785653002 Cr-Commit-Position: refs/heads/master@{#17453} Committed: https://chromium.googlesource.com/external/webrtc/+/3ff7a955525ffeff32f53c9d72fc6edcee66637a

Patch Set 1 #

Patch Set 2 : Roll latest revision. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -9 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
A tools-webrtc/gtest-parallel-wrapper.py View 1 chunk +107 lines, -0 lines 0 comments Download
M tools-webrtc/mb/mb.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools-webrtc/mb/mb_unittest.py View 3 chunks +6 lines, -6 lines 3 comments Download

Messages

Total messages: 22 (12 generated)
ehmaldonado_webrtc
3 years, 8 months ago (2017-03-29 09:50:57 UTC) #1
kjellander_webrtc
lgtm, make sure to run all trybots. Also, from now on it will be auto-rolled ...
3 years, 8 months ago (2017-03-29 10:49:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785653002/1
3 years, 8 months ago (2017-03-29 11:11:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/23151)
3 years, 8 months ago (2017-03-29 11:22:03 UTC) #6
ehmaldonado_webrtc
pbos: Just FYI.
3 years, 8 months ago (2017-03-29 16:31:33 UTC) #10
pbos-webrtc
On 2017/03/29 16:31:33, ehmaldonado_webrtc wrote: > pbos: Just FYI. lgtm :)
3 years, 8 months ago (2017-03-29 16:36:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785653002/20001
3 years, 8 months ago (2017-03-29 16:39:41 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/3ff7a955525ffeff32f53c9d72fc6edcee66637a
3 years, 8 months ago (2017-03-29 16:42:37 UTC) #20
pbos-webrtc
https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unittest.py File tools-webrtc/mb/mb_unittest.py (right): https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unittest.py#newcode483 tools-webrtc/mb/mb_unittest.py:483: '../../third_party/gtest-parallel/gtest-parallel', and this? https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unittest.py#newcode528 tools-webrtc/mb/mb_unittest.py:528: '../../third_party/gtest-parallel/gtest-parallel', this one too? ...
3 years, 8 months ago (2017-03-29 17:52:01 UTC) #21
ehmaldonado_webrtc
3 years, 8 months ago (2017-03-29 18:00:43 UTC) #22
Message was sent while issue was closed.
On 2017/03/29 17:52:01, pbos-webrtc wrote:
>
https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unitte...
> File tools-webrtc/mb/mb_unittest.py (right):
> 
>
https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unitte...
> tools-webrtc/mb/mb_unittest.py:483:
> '../../third_party/gtest-parallel/gtest-parallel',
> and this?
> 
>
https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unitte...
> tools-webrtc/mb/mb_unittest.py:528:
> '../../third_party/gtest-parallel/gtest-parallel',
> this one too?
> 
>
https://codereview.webrtc.org/2785653002/diff/20001/tools-webrtc/mb/mb_unitte...
> tools-webrtc/mb/mb_unittest.py:570:
> '../../third_party/gtest-parallel/gtest-parallel',
> and this

gtest-parallel is still being rolled in third_party/gtest-parallel, so those
paths are correct.
The difference is that now we're using a Chromium mirror, so we can update it
like this (or with an auto-roller script) instead of manually copying the latest
gtest-parallel file.

Those paths are from out/{Debug, Release, whatever}, btw.

Powered by Google App Engine
This is Rietveld 408576698