Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2785443002: Remove VoECodec from FakeWebRtcVoiceEngine. (Closed)

Created:
3 years, 8 months ago by the sun
Modified:
3 years, 8 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoECodec from FakeWebRtcVoiceEngine. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2785443002 Cr-Commit-Position: refs/heads/master@{#17420} Committed: https://chromium.googlesource.com/external/webrtc/+/83862e3c14a39065cb87e86a61536355f1c9284f

Patch Set 1 #

Patch Set 2 : one include too many #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -97 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 3 chunks +1 line, -86 lines 0 comments Download
M webrtc/media/engine/webrtcvoe.h View 1 chunk +3 lines, -9 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
the sun
3 years, 8 months ago (2017-03-28 11:31:13 UTC) #2
kwiberg-webrtc
lgtm
3 years, 8 months ago (2017-03-28 11:34:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785443002/20001
3 years, 8 months ago (2017-03-28 11:37:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 12:07:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/83862e3c14a39065cb87e86a6...

Powered by Google App Engine
This is Rietveld 408576698