Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2785113002: Avoid calling AudioEffect.queryEffects to avoid potential crash (Closed)

Created:
3 years, 8 months ago by henrika_webrtc
Modified:
3 years, 8 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid calling AudioEffect.queryEffects to avoid potential crash. BUG=b/36713041 NOTRY=TRUE Review-Url: https://codereview.webrtc.org/2785113002 Cr-Commit-Position: refs/heads/master@{#17461} Committed: https://chromium.googlesource.com/external/webrtc/+/4b4d833c31ed049de314f9eee13e4d2a04625df6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
henrika_webrtc
PTAL
3 years, 8 months ago (2017-03-30 07:56:47 UTC) #3
brandtr
lgtm
3 years, 8 months ago (2017-03-30 07:57:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2785113002/1
3 years, 8 months ago (2017-03-30 07:59:17 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 08:01:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4b4d833c31ed049de314f9eee...

Powered by Google App Engine
This is Rietveld 408576698