Chromium Code Reviews

Issue 2784873002: Delete unneeded includes of deprecated system_wrappers include files. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
kthelgason, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, AleBzk, peah-webrtc, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, fengyue_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, yujie_mao (webrtc), Andrew MacDonald, perkj_webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unneeded includes of deprecated system_wrappers include files. Deletes left-over includes of trace.h and critical_section_wrapper.h. BUG=webrtc:7035 Review-Url: https://codereview.webrtc.org/2784873002 Cr-Commit-Position: refs/heads/master@{#17460} Committed: https://chromium.googlesource.com/external/webrtc/+/0ffdcc51bccc55a7fbfbb75cf4c34571d657cb5d

Patch Set 1 #

Patch Set 2 : Delete unneeded includes of system_wrappers/include/critical_section_wrapper.h #

Unified diffs Side-by-side diffs Stats (+3 lines, -40 lines)
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/call/call.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/call/call_perf_tests.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/common_video/incoming_video_stream.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/acm2/acm_codec_database.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/test/TestRedFec.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/test/TestStereo.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/test/iSACTest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_coding/test/opus_test.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_device/linux/audio_mixer_manager_pulse_linux.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_device/linux/latebindingsymboltable_linux.h View 2 chunks +0 lines, -3 lines 0 comments
M webrtc/modules/audio_device/linux/latebindingsymboltable_linux.cc View 1 chunk +2 lines, -0 lines 0 comments
M webrtc/modules/audio_device/test/audio_device_test_defines.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_processing/level_estimator_impl.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/audio_processing/low_cut_filter.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_capture/objc/video_capture.mm View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/generic_encoder.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/media_opt_util.h View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/media_optimization.h View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/video_coding/receiver_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/timing_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/modules/video_coding/utility/frame_dropper.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/system_wrappers/source/condition_variable_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/system_wrappers/source/critical_section_unittest.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/video/vie_remb.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/voice_engine/file_player.cc View 1 chunk +0 lines, -1 line 0 comments
M webrtc/voice_engine/voe_network_impl.cc View 1 chunk +0 lines, -1 line 0 comments

Messages

Total messages: 11 (6 generated)
nisse-webrtc
PTAL. Removing unneeded includes makes it easier to see how much work is left before ...
3 years, 8 months ago (2017-03-29 15:12:46 UTC) #3
kwiberg-webrtc
lgtm Is there a real bug you can reference?
3 years, 8 months ago (2017-03-29 20:19:09 UTC) #4
nisse-webrtc
On 2017/03/29 20:19:09, kwiberg-webrtc wrote: > lgtm > > Is there a real bug you ...
3 years, 8 months ago (2017-03-30 06:11:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2784873002/20001
3 years, 8 months ago (2017-03-30 07:00:22 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 07:31:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0ffdcc51bccc55a7fbfbb75cf...

Powered by Google App Engine