Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2784543002: Revert of Don't hardcode MediaType::ANY in FakeNetworkPipe. (Closed)

Created:
3 years, 8 months ago by lliuu
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Don't hardcode MediaType::ANY in FakeNetworkPipe. (patchset #4 id:60001 of https://codereview.webrtc.org/2774463003/ ) Reason for revert: Reverting since this seems to break multiple WebRTC Perf buildbots Original issue's description: > Don't hardcode MediaType::ANY in FakeNetworkPipe. > > Instead let each test set the appropriate media type. This simplifies > demuxing in Call and later in RtpTransportController. > > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/2774463003 > Cr-Commit-Position: refs/heads/master@{#17418} > Committed: https://chromium.googlesource.com/external/webrtc/+/9c47b00e24da2941eb095df5a4459c6d98a8a88d TBR=stefan@webrtc.org,deadbeef@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,sprang@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/2784543002 Cr-Commit-Position: refs/heads/master@{#17427} Committed: https://chromium.googlesource.com/external/webrtc/+/3a3bd5061089da5327fc549337a8430054d66057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -128 lines) Patch
M webrtc/audio/test/low_bandwidth_audio_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/call/call.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/test/call_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/test/direct_transport.h View 2 chunks +3 lines, -12 lines 0 comments Download
M webrtc/test/direct_transport.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 3 chunks +2 lines, -5 lines 0 comments Download
M webrtc/test/fake_network_pipe.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/test/fake_network_pipe_unittest.cc View 15 chunks +26 lines, -26 lines 0 comments Download
M webrtc/test/layer_filtering_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 14 chunks +17 lines, -34 lines 0 comments Download
M webrtc/video/replay.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
lliuu
Created Revert of Don't hardcode MediaType::ANY in FakeNetworkPipe.
3 years, 8 months ago (2017-03-28 16:40:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2784543002/1
3 years, 8 months ago (2017-03-28 16:40:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3a3bd5061089da5327fc549337a8430054d66057
3 years, 8 months ago (2017-03-28 16:41:03 UTC) #6
nisse-webrtc
3 years, 8 months ago (2017-03-29 08:25:23 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2783853002/ by nisse@webrtc.org.

The reason for reverting is: Intend to fix perf failures and reland..

Powered by Google App Engine
This is Rietveld 408576698