Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2784333005: Merge UpdateBandwidthEstimate with Update in AimdRateControl. (Closed)

Created:
3 years, 8 months ago by terelius
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Merge UpdateBandwidthEstimate with Update in AimdRateControl. (The two functions are always called together anyway.) BUG=None Review-Url: https://codereview.webrtc.org/2784333005 Cr-Commit-Position: refs/heads/master@{#17502} Committed: https://chromium.googlesource.com/external/webrtc/+/d1b0e0e6dbbb7282d7e654cb2310b47b9a5d238a

Patch Set 1 #

Patch Set 2 : Remove updated_ and current_input_. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -48 lines) Patch
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h View 1 4 chunks +2 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc View 1 7 chunks +16 lines, -35 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
terelius
3 years, 8 months ago (2017-03-31 15:19:09 UTC) #2
terelius
Ready for review.
3 years, 8 months ago (2017-04-03 08:44:38 UTC) #5
stefan-webrtc
lgtm
3 years, 8 months ago (2017-04-03 08:50:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2784333005/20001
3 years, 8 months ago (2017-04-03 09:24:38 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:27:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d1b0e0e6dbbb7282d7e654cb2...

Powered by Google App Engine
This is Rietveld 408576698