Do not report quality limited resolution stats when quality scaler is disabled.

Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=webrtc:7432
Review-Url: https://codereview.webrtc.org/2783213002
Cr-Commit-Position: refs/heads/master@{#17487}
Committed: https://chromium.googlesource.com/external/webrtc/+/36e9eb4773d1a27d67ef632b9537bae82e3d6b6b

[åsapersson, 2017-03-30 16:15:55]

Patchset #3 (id:40001) has been deleted

[åsapersson, 2017-03-31 06:34:28]

Patchset #3 (id:60001) has been deleted

[åsapersson, 2017-03-31 06:53:15]

Description was changed from

==========
Update SetResolutionRestriction to specify....

BUG=
==========

to

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off.

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=
==========

[åsapersson, 2017-03-31 07:22:23]

Description was changed from

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off.

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=
==========

to

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=
==========

[åsapersson, 2017-03-31 07:22:23]

asapersson@webrtc.org changed reviewers:
+ kthelgason@webrtc.org, sprang@webrtc.org

[kthelgason, 2017-03-31 07:57:38]

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.cc:698: }
I think the amount of parameters and conditions here is getting a little unruly.

What do you think about simplifying this into two methods,
"SetCPUScalingStats(bool cpu_restricted)" and "SetQualityScalingStats(int
num_quality_downscales)" and making the decision of whether to report the stats
in the ViEEncoder? I think that would result in way simpler code here, and all
the decision making happens in ViEEncoder anyway, so it wouldn't add much there.

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/vie_encoder_...
File webrtc/video/vie_encoder_unittest.cc (right):

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/vie_encoder_...
webrtc/video/vie_encoder_unittest.cc:1075: test::FrameForwarder
new_video_source;
I guess the new source is technically not required, you can call SetSource with
the same source again.

[åsapersson, 2017-03-31 09:03:43]

Patchset #4 (id:90001) has been deleted

[åsapersson, 2017-03-31 09:06:25]

Patchset #4 (id:110001) has been deleted

[åsapersson, 2017-03-31 09:41:26]

Patchset #5 (id:150001) has been deleted

[åsapersson, 2017-03-31 09:53:38]

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.cc:698: }
On 2017/03/31 07:57:38, kthelgason wrote:
> I think the amount of parameters and conditions here is getting a little
unruly.
> 
> What do you think about simplifying this into two methods,
> "SetCPUScalingStats(bool cpu_restricted)" and "SetQualityScalingStats(int
> num_quality_downscales)" and making the decision of whether to report the
stats
> in the ViEEncoder? I think that would result in way simpler code here, and all
> the decision making happens in ViEEncoder anyway, so it wouldn't add much
there.

Done.

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/vie_encoder_...
File webrtc/video/vie_encoder_unittest.cc (right):

https://codereview.webrtc.org/2783213002/diff/70001/webrtc/video/vie_encoder_...
webrtc/video/vie_encoder_unittest.cc:1075: test::FrameForwarder
new_video_source;
On 2017/03/31 07:57:38, kthelgason wrote:
> I guess the new source is technically not required, you can call SetSource
with
> the same source again.

Done.

[kthelgason, 2017-03-31 11:11:58]

lgtm!

[åsapersson, 2017-03-31 11:23:23]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 11:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-31 11:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 11:28:25]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15655)

[åsapersson, 2017-03-31 11:28:37]

Description was changed from

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=
==========

to

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=webrtc:7432
==========

[åsapersson, 2017-03-31 12:18:30]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2017-03-31 12:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-31 12:29:13]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1490962710644070,
"parent_rev": "3883ccb5d78dc7368c2f57cf3f4a477f83547f01", "commit_rev":
"36e9eb4773d1a27d67ef632b9537bae82e3d6b6b"}

[commit-bot: I haz the power, 2017-03-31 12:29:15]

Description was changed from

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=webrtc:7432
==========

to

==========
Do not report quality limited resolution stats when quality scaler is disabled.

WebRTC.Video.QualityLimitedResolutionInPercent is reported as zero for calls
when the quality scaler is off (and the degradation preference allows scaling).

Update SetResolutionRestrictionStats to specify if quality scaler is enabled.

BUG=webrtc:7432

Review-Url: https://codereview.webrtc.org/2783213002
Cr-Commit-Position: refs/heads/master@{#17487}
Committed:
https://chromium.googlesource.com/external/webrtc/+/36e9eb4773d1a27d67ef632b9...
==========

[commit-bot: I haz the power, 2017-03-31 12:29:18]

Committed patchset #5 (id:170001) as
https://chromium.googlesource.com/external/webrtc/+/36e9eb4773d1a27d67ef632b9...