|
Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #8 id:410001 of https://codereview.webrtc.org/2781433002/ )
Reason for revert:
This has resulted in failure of CallPerfTest.ReceivesCpuOveruseAndUnderuse test on the Win7 build bot https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1780
Original issue's description:
> Reland of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #1 id:1 of https://codereview.webrtc.org/2764133002/ )
>
> Reason for revert:
> Found issue with test case, will add fix to reland cl.
>
> Original issue's description:
> > Revert of Add framerate to VideoSinkWants and ability to signal on overuse (patchset #14 id:250001 of https://codereview.webrtc.org/2716643002/ )
> >
> > Reason for revert:
> > Breaks perf tests:
> > https://build.chromium.org/p/client.webrtc.perf/builders/Win7/builds/1679
> > https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/2325
> >
> > Original issue's description:
> > > Add framerate to VideoSinkWants and ability to signal on overuse
> > >
> > > In ViEEncoder, try to reduce framerate instead of resolution if the
> > > current degradation preference is maintain-resolution rather than
> > > balanced.
> > >
> > > BUG= webrtc:4172
> > >
> > > Review-Url: https://codereview.webrtc.org/2716643002
> > > Cr-Commit-Position: refs/heads/master@{#17327}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/72acf2526177bb4dbb5103cd6e165eb4361a5ae6
> >
> > TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,sprang@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= webrtc:4172
> >
> > Review-Url: https://codereview.webrtc.org/2764133002
> > Cr-Commit-Position: refs/heads/master@{#17331}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/8b45b11144c968b4173215c76f78c710c9a2ed0b
>
> TBR=nisse@webrtc.org,magjed@webrtc.org,kthelgason@webrtc.org,ilnik@webrtc.org,stefan@webrtc.org,skvlad@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= webrtc:4172
>
> Review-Url: https://codereview.webrtc.org/2781433002
> Cr-Commit-Position: refs/heads/master@{#17474}
> Committed: https://chromium.googlesource.com/external/webrtc/+/3ea3c77e93121b1ab9d5e46641e6764f2cca0d51
TBR=ilnik@webrtc.org,stefan@webrtc.org,asapersson@webrtc.org,sprang@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= webrtc:4172
Review-Url: https://codereview.webrtc.org/2783183003
Cr-Commit-Position: refs/heads/master@{#17477}
Committed: https://chromium.googlesource.com/external/webrtc/+/f9ed235c9b7248694edcb46feb1f29ce7456ab59
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+496 lines, -1455 lines) |
Patch |
|
M |
webrtc/call/bitrate_estimator_tests.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/call/call_perf_tests.cc
|
View
|
|
3 chunks |
+17 lines, -40 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/adaptedvideotracksource.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/fakevideocapturer.h
|
View
|
|
2 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/fakevideorenderer.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/media/base/videoadapter.h
|
View
|
|
3 chunks |
+7 lines, -14 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videoadapter.cc
|
View
|
|
4 chunks |
+11 lines, -26 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videoadapter_unittest.cc
|
View
|
|
29 chunks |
+50 lines, -117 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videobroadcaster.cc
|
View
|
|
2 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videobroadcaster_unittest.cc
|
View
|
|
2 chunks |
+6 lines, -29 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videocapturer.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videocapturer_unittest.cc
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
webrtc/media/base/videosourceinterface.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/media/engine/fakewebrtccall.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/media/engine/fakewebrtccall.cc
|
View
|
|
3 chunks |
+4 lines, -22 lines |
0 comments
|
Download
|
|
M |
webrtc/media/engine/webrtcvideoengine2.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/media/engine/webrtcvideoengine2.cc
|
View
|
|
3 chunks |
+23 lines, -24 lines |
0 comments
|
Download
|
|
M |
webrtc/media/engine/webrtcvideoengine2_unittest.cc
|
View
|
|
8 chunks |
+24 lines, -54 lines |
0 comments
|
Download
|
|
M |
webrtc/test/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/test/call_test.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/test/frame_generator_capturer.h
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/test/frame_generator_capturer.cc
|
View
|
|
6 chunks |
+49 lines, -86 lines |
0 comments
|
Download
|
|
M |
webrtc/test/vcm_capturer.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/test/vcm_capturer.cc
|
View
|
|
6 chunks |
+12 lines, -16 lines |
0 comments
|
Download
|
|
M |
webrtc/test/video_capturer.h
|
View
|
|
1 chunk |
+5 lines, -24 lines |
0 comments
|
Download
|
|
D |
webrtc/test/video_capturer.cc
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
|
M |
webrtc/video/end_to_end_tests.cc
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
webrtc/video/overuse_frame_detector.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
webrtc/video/overuse_frame_detector.cc
|
View
|
|
7 chunks |
+4 lines, -93 lines |
0 comments
|
Download
|
|
M |
webrtc/video/send_statistics_proxy.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/video/video_quality_test.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/video/video_send_stream_tests.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
webrtc/video/vie_encoder.h
|
View
|
|
5 chunks |
+3 lines, -16 lines |
0 comments
|
Download
|
|
M |
webrtc/video/vie_encoder.cc
|
View
|
|
11 chunks |
+82 lines, -272 lines |
0 comments
|
Download
|
|
M |
webrtc/video/vie_encoder_unittest.cc
|
View
|
|
29 chunks |
+164 lines, -493 lines |
0 comments
|
Download
|
|
M |
webrtc/video_send_stream.h
|
View
|
|
1 chunk |
+2 lines, -11 lines |
0 comments
|
Download
|
Total messages: 7 (3 generated)
|