Replace Clock with timeutils in AudioEncoder.

Replace Clock with timeutils in AudioEncoder.

BUG=webrtc:7398
Review-Url: https://codereview.webrtc.org/2782563003
Cr-Commit-Position: refs/heads/master@{#17732}
Committed: https://chromium.googlesource.com/external/webrtc/+/92aef17cb23d59bdbcca1211c317970506502f34

[michaelt, 2017-03-28 09:45:37]

Description was changed from

==========
Replace old time API

BUG=webrtc:7398
==========

to

==========
Replace old time API

BUG=webrtc:7398
==========

[michaelt, 2017-03-28 09:45:37]

michaelt@webrtc.org changed reviewers:
+ minyue@webrtc.org

[michaelt, 2017-04-03 12:09:45]

Hi i have rebased this.

[michaelt, 2017-04-05 10:19:20]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 10:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-05 10:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 10:28:41]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/24997)

[michaelt, 2017-04-06 08:01:40]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 08:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 08:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 08:26:52]

Dry run: This issue passed the CQ dry run.

[minyue-webrtc, 2017-04-06 10:57:54]

cool!

+ Please update the title and description to say "Replace Clock with timeutils
in AudioEncoder"

[michaelt, 2017-04-06 11:30:42]

Description was changed from

==========
Replace old time API

BUG=webrtc:7398
==========

to

==========
Replace Clock with timeutils in AudioEncoder

BUG=webrtc:7398
==========

[michaelt, 2017-04-06 11:30:53]

On 2017/04/06 10:57:54, minyue-webrtc wrote:
> cool!
> 
> + Please update the title and description to say "Replace Clock with timeutils
> in AudioEncoder"

Done

[michaelt, 2017-04-06 12:06:28]

The CQ bit was checked by michaelt@webrtc.org

[commit-bot: I haz the power, 2017-04-06 12:06:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-06 12:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 12:06:35]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[michaelt, 2017-04-06 12:06:41]

The CQ bit was unchecked by michaelt@webrtc.org

[minyue-webrtc, 2017-04-06 19:10:55]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2017-04-06 19:10:56]

lgtm

[commit-bot: I haz the power, 2017-04-06 19:11:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[minyue-webrtc, 2017-04-06 19:11:35]

Description was changed from

==========
Replace Clock with timeutils in AudioEncoder

BUG=webrtc:7398
==========

to

==========
Replace Clock with timeutils in AudioEncoder.

BUG=webrtc:7398
==========

[commit-bot: I haz the power, 2017-04-06 19:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 19:15:12]

Try jobs failed on following builders:
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/176)

[minyue-webrtc, 2017-04-07 06:29:41]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2017-04-07 06:29:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-07 06:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:33:54]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15877)

[minyue-webrtc, 2017-04-07 09:48:11]

On 2017/04/07 06:33:54, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15877)

Please fix

[michaelt, 2017-04-10 07:41:46]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 07:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 08:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 08:51:28]

Dry run: This issue passed the CQ dry run.

[michaelt, 2017-04-10 12:03:20]

The CQ bit was checked by michaelt@webrtc.org

[michaelt, 2017-04-10 12:03:21]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2782563003/#ps60001 (title:
"Rebased")

[commit-bot: I haz the power, 2017-04-10 12:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 12:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 12:08:16]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15984)

[michaelt, 2017-04-10 13:25:43]

michaelt@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[michaelt, 2017-04-10 13:26:22]

@kwiberg@webrtc.org
Hi could you take a look, to the common audio part of the CL ?

[kwiberg-webrtc, 2017-04-11 12:18:38]

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
File webrtc/common_audio/smoothing_filter_unittest.cc (right):

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
webrtc/common_audio/smoothing_filter_unittest.cc:26:
std::unique_ptr<rtc::ScopedFakeClock> fake_clock;
This doesn't look quite right. IIUC the intention is that you should put
ScopedFakeClock on the stack. (It should work to do it this way too, but it's
more complicated than necessary.)

[michaelt, 2017-04-11 14:11:13]

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
File webrtc/common_audio/smoothing_filter_unittest.cc (right):

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
webrtc/common_audio/smoothing_filter_unittest.cc:26:
std::unique_ptr<rtc::ScopedFakeClock> fake_clock;
I think you are right that this class was meant to be on the stack.
But in terms of these tests i think the code would get more complicated when i
created the ScopedFakeClock for each test on the stack.
Because of:
a) I would have to set the init time each time after creating it.
b) I would have to pass it separately to the CheckOutput function.

[kwiberg-webrtc, 2017-04-11 16:46:57]

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
File webrtc/common_audio/smoothing_filter_unittest.cc (right):

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
webrtc/common_audio/smoothing_filter_unittest.cc:26:
std::unique_ptr<rtc::ScopedFakeClock> fake_clock;
On 2017/04/11 14:11:13, michaelt wrote:
> I think you are right that this class was meant to be on the stack.
> But in terms of these tests i think the code would get more complicated when i
> created the ScopedFakeClock for each test on the stack.
> Because of:
> a) I would have to set the init time each time after creating it.
> b) I would have to pass it separately to the CheckOutput function.

OK. But could you at least get rid of the unique_ptr and store the
ScopedFakeClock directly in the struct?

[michaelt, 2017-04-12 07:17:57]

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
File webrtc/common_audio/smoothing_filter_unittest.cc (right):

https://codereview.webrtc.org/2782563003/diff/60001/webrtc/common_audio/smoot...
webrtc/common_audio/smoothing_filter_unittest.cc:26:
std::unique_ptr<rtc::ScopedFakeClock> fake_clock;
On 2017/04/11 16:46:57, kwiberg-webrtc wrote:
> On 2017/04/11 14:11:13, michaelt wrote:
> > I think you are right that this class was meant to be on the stack.
> > But in terms of these tests i think the code would get more complicated when
i
> > created the ScopedFakeClock for each test on the stack.
> > Because of:
> > a) I would have to set the init time each time after creating it.
> > b) I would have to pass it separately to the CheckOutput function.
> 
> OK. But could you at least get rid of the unique_ptr and store the
> ScopedFakeClock directly in the struct?

Done

[kwiberg-webrtc, 2017-04-12 07:27:03]

lgtm for common_audio

[michaelt, 2017-04-12 09:20:11]

The CQ bit was checked by michaelt@webrtc.org

[michaelt, 2017-04-12 09:20:11]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2782563003/#ps80001 (title:
"Respond to comment")

[commit-bot: I haz the power, 2017-04-12 09:20:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 09:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 09:41:19]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/18153)

[michaelt, 2017-04-12 10:52:58]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 10:53:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 11:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 11:09:47]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[michaelt, 2017-04-13 14:13:56]

Patchset #6 (id:100001) has been deleted

[michaelt, 2017-04-13 14:14:30]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 14:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-13 14:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:36:03]

Dry run: This issue passed the CQ dry run.

[michaelt, 2017-04-18 06:47:31]

The CQ bit was checked by michaelt@webrtc.org

[michaelt, 2017-04-18 06:47:32]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org,
minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2782563003/#ps120001 (title:
"Fix for failing unittest.")

[commit-bot: I haz the power, 2017-04-18 06:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-18 07:11:48]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492498051478690,
"parent_rev": "639c4871872e91143d75d2ae4b7abdb22962f61c", "commit_rev":
"92aef17cb23d59bdbcca1211c317970506502f34"}

[commit-bot: I haz the power, 2017-04-18 07:11:53]

Description was changed from

==========
Replace Clock with timeutils in AudioEncoder.

BUG=webrtc:7398
==========

to

==========
Replace Clock with timeutils in AudioEncoder.

BUG=webrtc:7398

Review-Url: https://codereview.webrtc.org/2782563003
Cr-Commit-Position: refs/heads/master@{#17732}
Committed:
https://chromium.googlesource.com/external/webrtc/+/92aef17cb23d59bdbcca1211c...
==========

[commit-bot: I haz the power, 2017-04-18 07:11:54]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/92aef17cb23d59bdbcca1211c...