Visualize events related to probing in the total bitrate graph.

Visualize events related to probing in the total bitrate graph.

BUG=webrtc:6984
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2782553005 .
Cr-Commit-Position: refs/heads/master@{#17449}
Committed: https://chromium.googlesource.com/external/webrtc/+/e127e7a0edabaec02d34dd4a6b56bce54d7f5045

[philipel, 2017-03-28 14:38:39]

philipel@webrtc.org changed reviewers:
+ terelius@webrtc.org

[terelius, 2017-03-28 15:02:56]

Could you add POINT_CHART to ChartStyle in chart.proto
and
data_set->set_style(POINT_CHART);
data_set->set_highlight_points(true);
in plot_protobuf.cc?

https://codereview.webrtc.org/2782553005/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/plot_python.cc (right):

https://codereview.webrtc.org/2782553005/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/plot_python.cc:81: "marker='o', ls=' ')\n",
Is there a reason for using marker='o' instead of marker='.'? For protobuf
output, there will only be one type of marker/highlight for points.

[philipel, 2017-03-29 09:54:57]

PTAL

https://codereview.webrtc.org/2782553005/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/plot_python.cc (right):

https://codereview.webrtc.org/2782553005/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/plot_python.cc:81: "marker='o', ls=' ')\n",
On 2017/03/28 15:02:56, terelius wrote:
> Is there a reason for using marker='o' instead of marker='.'? For protobuf
> output, there will only be one type of marker/highlight for points.

Changed to '.'.

[terelius, 2017-03-29 11:01:58]

https://codereview.webrtc.org/2782553005/diff/20001/webrtc/tools/event_log_vi...
File webrtc/tools/event_log_visualizer/chart.proto (right):

https://codereview.webrtc.org/2782553005/diff/20001/webrtc/tools/event_log_vi...
webrtc/tools/event_log_visualizer/chart.proto:13: DOT_GRAPH = 4;
To be consistent with the other names, I'd like to call this SCATTER_CHART.

[philipel, 2017-03-29 11:05:15]

https://codereview.webrtc.org/2782553005/diff/20001/webrtc/tools/event_log_vi...
File webrtc/tools/event_log_visualizer/chart.proto (right):

https://codereview.webrtc.org/2782553005/diff/20001/webrtc/tools/event_log_vi...
webrtc/tools/event_log_visualizer/chart.proto:13: DOT_GRAPH = 4;
On 2017/03/29 11:01:58, terelius wrote:
> To be consistent with the other names, I'd like to call this SCATTER_CHART.

Done.

[terelius, 2017-03-29 11:14:46]

lgtm

[philipel, 2017-03-29 11:16:03]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-03-29 11:16:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 11:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:32:29]

Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/7221)

[philipel, 2017-03-29 13:50:03]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-03-29 13:50:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 13:55:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:55:37]

Try jobs failed on following builders:
  linux_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_rel/builds/10)

[philipel, 2017-03-29 14:28:57]

Description was changed from

==========
Visualize events related to probing in the total bitrate graph.

BUG=webrtc:6984
==========

to

==========
Visualize events related to probing in the total bitrate graph.

BUG=webrtc:6984
R=terelius@webrtc.org

Review-Url: https://codereview.webrtc.org/2782553005 .
Cr-Commit-Position: refs/heads/master@{#17449}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e127e7a0edabaec02d34dd4a6...
==========

[philipel, 2017-03-29 14:28:59]

Committed patchset #3 (id:40001) manually as
e127e7a0edabaec02d34dd4a6b56bce54d7f5045 (presubmit successful).