Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2782163002: Disable P2PTransportChannelMultihomedTest test on memcheck. (Closed)

Created:
3 years, 8 months ago by aleloi
Modified:
3 years, 8 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable P2PTransportChannelMultihomedTest test on memcheck. The test P2PTransportChannelMultihomedTest.TestContinualGatheringOnNewInterface fails on Linux memcheck with the following error: ../../webrtc/p2p/base/p2ptransportchannel_unittest.cc:2780: Failure Value of: ep1_ch1()->GetState() == IceTransportState::STATE_COMPLETED && (conn = GetConnectionWithLocalAddress(ep1_ch1(), cellular[0])) != nullptr && conn != ep1_ch1()->selected_connection() && conn->writable() Actual: false Expected: true TBR=honghaiz@webrtc.org BUG=webrtc:7421 NOTRY=true Review-Url: https://codereview.webrtc.org/2782163002 Cr-Commit-Position: refs/heads/master@{#17445} Committed: https://chromium.googlesource.com/external/webrtc/+/dbd0a21a5d82aa30f34bd95488103edf08bf69c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools-webrtc/valgrind/gtest_exclude/rtc_media_unittests.gtest-memcheck.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782163002/1
3 years, 8 months ago (2017-03-29 12:01:09 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-29 12:01:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2782163002/1
3 years, 8 months ago (2017-03-29 12:02:09 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 12:04:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dbd0a21a5d82aa30f34bd9548...

Powered by Google App Engine
This is Rietveld 408576698