Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2781663005: Added licence boilerplate to our MATLAB files. (Closed)

Created:
3 years, 9 months ago by aleloi
Modified:
3 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added licence boilerplate to our MATLAB files. The command tools/checklicenses/checklicenses.py --ignore-suppressions ./webrtc previously produced this output: 'webrtc/modules/audio_processing/test/apmtest.m' has non-whitelisted license 'UNKNOWN' 'webrtc/modules/audio_processing/transient/test/readDetection.m' has non-whitelisted license 'UNKNOWN' 'webrtc/modules/audio_processing/transient/test/readPCM.m' has non-whitelisted license 'UNKNOWN' ... This CL adds the WebRTC licence with appropriate year to all our MATLAB files. All these files were contributed by WebRTC project members hlundin@, pbos@, niklase@. BUG=chromium:98592 NOTRY=True Review-Url: https://codereview.webrtc.org/2781663005 Cr-Commit-Position: refs/heads/master@{#17428} Committed: https://chromium.googlesource.com/external/webrtc/+/0e4a6855427fc798fe4be1fc2761796c227627e7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update year in licence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/ilbc/complexityMeasures.m View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/delay_tool/plot_neteq_delay.m View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/apmtest.m View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/transient/test/plotDetection.m View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/transient/test/readDetection.m View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/transient/test/readPCM.m View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
aleloi
Any thoughts?
3 years, 9 months ago (2017-03-28 08:39:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781663005/1
3 years, 9 months ago (2017-03-28 09:44:06 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-28 09:44:08 UTC) #8
hlundin-webrtc
LGTM with two comments. https://codereview.webrtc.org/2781663005/diff/1/webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m File webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m (right): https://codereview.webrtc.org/2781663005/diff/1/webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m#newcode2 webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m:2: % Copyright (c) 2013 The ...
3 years, 9 months ago (2017-03-28 12:01:14 UTC) #9
hlundin-webrtc
On 2017/03/28 12:01:14, hlundin-webrtc wrote: > LGTM with two comments. > > https://codereview.webrtc.org/2781663005/diff/1/webrtc/modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m > File ...
3 years, 9 months ago (2017-03-28 12:02:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781663005/20001
3 years, 8 months ago (2017-03-28 17:16:47 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:19:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0e4a6855427fc798fe4be1fc2...

Powered by Google App Engine
This is Rietveld 408576698