ScreenCapturerWinDirectx flickers in Desktop Capturer Sample

webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

Index: webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h
diff --git a/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h b/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h
index a48bda9954bd7e316474aa3701de33a03bf033f6..98283b6c37db9d8ebd4d80079c3fe34ea1754081 100644
--- a/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h
+++ b/webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h
@@ -60,9 +60,9 @@ class ScreenCapturerWinDirectx : public DesktopCapturer {
   DesktopSize SelectedDesktopSize() const;
 
   ScreenCaptureFrameQueue<SharedDesktopFrame> frames_;
+  ScreenCaptureFrameQueue<DxgiDuplicatorController::Context> contexts_;

[Sergey Ulanov, 2017/03/30 17:59:41]

Add a struct that holds a Context together with a frame, then they can be stored
together in the same queue.

[Hzj_jie, 2017/03/30 18:11:18]

I am happy to do so. But considering this change is going to be merged to M58. I
would prefer to keep it as small as possible.
How about let's do it in a different change? I think the logic of generating a
new SharedDesktopFrame can also be moved to the structure. And meanwhile, I
would need to consider the way to reset several contexts in the FrameQueue,
which would make the change even larger.

[Sergey Ulanov, 2017/03/31 19:28:53]

Add a TODO?

[Hzj_jie, 2017/03/31 20:39:52]

Definitely.

   std::unique_ptr<SharedMemoryFactory> shared_memory_factory_;
   Callback* callback_ = nullptr;
-  DxgiDuplicatorController::Context context_;
   SourceId current_screen_id_ = kFullDesktopScreenId;
   ResolutionChangeDetector resolution_change_detector_;