ScreenCapturerWinDirectx flickers in Desktop Capturer Sample

webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 42 matching lines @@
       std::unique_ptr<SharedMemoryFactory> shared_memory_factory) override;
   void CaptureFrame() override;
   bool GetSourceList(SourceList* sources) override;
   bool SelectSource(SourceId id) override;
 
  private:
   // Returns desktop size of selected screen.
   DesktopSize SelectedDesktopSize() const;
 
   ScreenCaptureFrameQueue<SharedDesktopFrame> frames_;
+  ScreenCaptureFrameQueue<DxgiDuplicatorController::Context> contexts_;

[Sergey Ulanov, 2017/03/30 17:59:41]

Add a struct that holds a Context together with a frame, then they can be stored
together in the same queue.

[Hzj_jie, 2017/03/30 18:11:18]

I am happy to do so. But considering this change is going to be merged to M58. I
would prefer to keep it as small as possible.
How about let's do it in a different change? I think the logic of generating a
new SharedDesktopFrame can also be moved to the structure. And meanwhile, I
would need to consider the way to reset several contexts in the FrameQueue,
which would make the change even larger.

[Sergey Ulanov, 2017/03/31 19:28:53]

Add a TODO?

[Hzj_jie, 2017/03/31 20:39:52]

Definitely.

   std::unique_ptr<SharedMemoryFactory> shared_memory_factory_;
   Callback* callback_ = nullptr;
-  DxgiDuplicatorController::Context context_;
   SourceId current_screen_id_ = kFullDesktopScreenId;
   ResolutionChangeDetector resolution_change_detector_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(ScreenCapturerWinDirectx);
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_DESKTOP_CAPTURE_WIN_SCREEN_CAPTURER_WIN_DIRECTX_H_