Fix deprecated methods in AppRTCMobile.

Fix deprecated methods in AppRTCMobile.

Remove warning suppressions and update code that uses deprecated methods
to the currently supported APIs.

BUG=webrtc:5549
Review-Url: https://codereview.webrtc.org/2780433006
Cr-Commit-Position: refs/heads/master@{#17472}
Committed: https://chromium.googlesource.com/external/webrtc/+/b13237b9dafd0ffbca64eba167d58a0dad410055

[kthelgason, 2017-03-29 09:35:59]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-03-29 09:36:16]

kthelgason@webrtc.org changed reviewers:
+ denicija@webrtc.org, magjed@webrtc.org

[commit-bot: I haz the power, 2017-03-29 10:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:09:15]

Dry run: This issue passed the CQ dry run.

[daniela-webrtc, 2017-03-29 12:25:56]

LGTM

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m (right):

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:79: 
Nit: remove extra line

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:146: [NSURLConnection
sendAsyncRequest:request
Is it gonna be too much work to update to NSURLSession here as well, since
NSURLConnection is deprecated and we're changing the implementation anyhow.

[kthelgason, 2017-03-29 12:35:25]

Thanks for the review!

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m (right):

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:79: 
On 2017/03/29 12:25:56, daniela-webrtc wrote:
> Nit: remove extra line

Done.

https://codereview.webrtc.org/2780433006/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:146: [NSURLConnection
sendAsyncRequest:request
On 2017/03/29 12:25:56, daniela-webrtc wrote:
> Is it gonna be too much work to update to NSURLSession here as well, since
> NSURLConnection is deprecated and we're changing the implementation anyhow.

This is actually using NSURLSession, it's calling a method on our monkey-patched
version of NSURLConnection (see ARDUtilities.m)

[magjed_webrtc, 2017-03-29 20:03:47]

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m (right):

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:144: dispatch_semaphore_t
sem = dispatch_semaphore_create(0);
Maybe use rtc::Event instead?

[kthelgason, 2017-03-30 08:58:53]

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m (right):

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:144: dispatch_semaphore_t
sem = dispatch_semaphore_create(0);
On 2017/03/29 20:03:46, magjed_webrtc wrote:
> Maybe use rtc::Event instead?

This is a pure ObjC file, and I'd prefer to keep it that way. Lets not add
unnecessary dependencies on base.

[magjed_webrtc, 2017-03-30 11:19:46]

lgtm

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m (right):

https://codereview.webrtc.org/2780433006/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCMobile/ARDAppEngineClient.m:144: dispatch_semaphore_t
sem = dispatch_semaphore_create(0);
On 2017/03/30 08:58:53, kthelgason wrote:
> On 2017/03/29 20:03:46, magjed_webrtc wrote:
> > Maybe use rtc::Event instead?
> 
> This is a pure ObjC file, and I'd prefer to keep it that way. Lets not add
> unnecessary dependencies on base.

Acknowledged.

[kthelgason, 2017-03-30 11:22:32]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-03-30 11:22:32]

The patchset sent to the CQ was uploaded after l-g-t-m from denicija@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2780433006/#ps20001 (title:
"fix nits")

[commit-bot: I haz the power, 2017-03-30 11:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 11:56:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490872952553500,
"parent_rev": "18703f95832ab89c6060e8b24c6ab28ec480a298", "commit_rev":
"b13237b9dafd0ffbca64eba167d58a0dad410055"}

[commit-bot: I haz the power, 2017-03-30 11:56:14]

Description was changed from

==========
Fix deprecated methods in AppRTCMobile.

Remove warning suppressions and update code that uses deprecated methods
to the currently supported APIs.

BUG=webrtc:5549
==========

to

==========
Fix deprecated methods in AppRTCMobile.

Remove warning suppressions and update code that uses deprecated methods
to the currently supported APIs.

BUG=webrtc:5549

Review-Url: https://codereview.webrtc.org/2780433006
Cr-Commit-Position: refs/heads/master@{#17472}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b13237b9dafd0ffbca64eba16...
==========

[commit-bot: I haz the power, 2017-03-30 11:56:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b13237b9dafd0ffbca64eba16...