|
|
Created:
3 years, 9 months ago by Ken Rockot(use gerrit already) Modified:
3 years, 9 months ago Reviewers:
yzshen1 CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix leaks in mojo::edk::NodeController
There are a few instances where the broker process (e.g. the browser in
process Chrome) tracks some state -- including outgoing messages --
pertaining to a client process connection. In some cases this tracked data
is not cleaned up once the client process is disconnected. This fixes that.
BUG=704938
Review-Url: https://codereview.chromium.org/2780433003
Cr-Commit-Position: refs/heads/master@{#460001}
Committed: https://chromium.googlesource.com/chromium/src/+/69726f4ba3947fd4ddbfb07fd9f1a596289cdae9
Patch Set 1 : . #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
rockot@chromium.org changed reviewers: + yzshen@chromium.org
Hi Yuzhu, would you mind taking a quick look at this?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rockot@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix leaks in mojo::edk::NodeController There are a few instances where the broker process (e.g. the browser in process Chrome) tracks some state (including outgoing messages) pertaining to some external process connection. In some cases this tracked data is not cleaned up once the process is disconnected. This fixes that. BUG=704938 ========== to ========== Fix leaks in mojo::edk::NodeController There are a few instances where the broker process (e.g. the browser in process Chrome) tracks some state -- including outgoing messages -- pertaining to a client process connection. In some cases this tracked data is not cleaned up once the client process is disconnected. This fixes that. BUG=704938 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by rockot@chromium.org
The CQ bit was checked by rockot@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org Link to the patchset: https://codereview.chromium.org/2780433003/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490670380289920, "parent_rev": "4ea301f06b3c94bc2cf9a8be6ca151e3c01987ba", "commit_rev": "69726f4ba3947fd4ddbfb07fd9f1a596289cdae9"}
Message was sent while issue was closed.
Description was changed from ========== Fix leaks in mojo::edk::NodeController There are a few instances where the broker process (e.g. the browser in process Chrome) tracks some state -- including outgoing messages -- pertaining to a client process connection. In some cases this tracked data is not cleaned up once the client process is disconnected. This fixes that. BUG=704938 ========== to ========== Fix leaks in mojo::edk::NodeController There are a few instances where the broker process (e.g. the browser in process Chrome) tracks some state -- including outgoing messages -- pertaining to a client process connection. In some cases this tracked data is not cleaned up once the client process is disconnected. This fixes that. BUG=704938 Review-Url: https://codereview.chromium.org/2780433003 Cr-Commit-Position: refs/heads/master@{#460001} Committed: https://chromium.googlesource.com/chromium/src/+/69726f4ba3947fd4ddbfb07fd9f1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/69726f4ba3947fd4ddbfb07fd9f1... |