Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2780433003: Fix leaks in mojo::edk::NodeController (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix leaks in mojo::edk::NodeController There are a few instances where the broker process (e.g. the browser in process Chrome) tracks some state -- including outgoing messages -- pertaining to a client process connection. In some cases this tracked data is not cleaned up once the client process is disconnected. This fixes that. BUG=704938 Review-Url: https://codereview.chromium.org/2780433003 Cr-Commit-Position: refs/heads/master@{#460001} Committed: https://chromium.googlesource.com/chromium/src/+/69726f4ba3947fd4ddbfb07fd9f1a596289cdae9

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M mojo/edk/system/node_controller.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Ken Rockot(use gerrit already)
Hi Yuzhu, would you mind taking a quick look at this?
3 years, 9 months ago (2017-03-28 00:37:34 UTC) #3
yzshen1
LGTM
3 years, 9 months ago (2017-03-28 00:49:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780433003/1
3 years, 9 months ago (2017-03-28 00:50:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/349237)
3 years, 9 months ago (2017-03-28 01:30:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780433003/20001
3 years, 9 months ago (2017-03-28 03:06:23 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:39:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69726f4ba3947fd4ddbfb07fd9f1...

Powered by Google App Engine
This is Rietveld 408576698