Fix JNI reference leak in MediaCodecVideoDecoder

Fix JNI reference leak in MediaCodecVideoDecoder

We currently leak one local reference to MediaCodecVideoDecoder in
every call to MediaCodecVideoDecoderFactory::CreateVideoDecoder. After
the decoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoDecoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969
,b/36713034

Review-Url: https://codereview.webrtc.org/2780273002
Cr-Commit-Position: refs/heads/master@{#17464}
Committed: https://chromium.googlesource.com/external/webrtc/+/e4cd15d379b1a0bf1f91aaf873cfa07b0998f295

[magjed_webrtc, 2017-03-29 19:53:07]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 19:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-03-29 20:10:46]

Description was changed from

==========
Fix JNI reference leak in MediaCodecVideoDecoder

We currently leak one local reference to MediaCodecVideoDecoder in
every call to MediaCodecVideoDecoderFactory::CreateVideoDecoder. After
the decoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoDecoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/36713034
==========

to

==========
Fix JNI reference leak in MediaCodecVideoDecoder

We currently leak one local reference to MediaCodecVideoDecoder in
every call to MediaCodecVideoDecoderFactory::CreateVideoDecoder. After
the decoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoDecoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/36713034
==========

[magjed_webrtc, 2017-03-29 20:10:46]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2017-03-29 20:10:57]

Sami - please take a look.

[commit-bot: I haz the power, 2017-03-29 20:25:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:25:11]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-03-30 07:18:25]

lgtm

[magjed_webrtc, 2017-03-30 08:04:20]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-03-30 08:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 08:08:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490861060676730, "parent_rev":
"b12a3e342728f66238eaa158264af9a483bf6fd0", "commit_rev":
"e4cd15d379b1a0bf1f91aaf873cfa07b0998f295"}

[commit-bot: I haz the power, 2017-03-30 08:08:40]

Description was changed from

==========
Fix JNI reference leak in MediaCodecVideoDecoder

We currently leak one local reference to MediaCodecVideoDecoder in
every call to MediaCodecVideoDecoderFactory::CreateVideoDecoder. After
the decoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoDecoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/36713034
==========

to

==========
Fix JNI reference leak in MediaCodecVideoDecoder

We currently leak one local reference to MediaCodecVideoDecoder in
every call to MediaCodecVideoDecoderFactory::CreateVideoDecoder. After
the decoder has been re-initialized 512 times, JNI will crash due to
local reference table overflow (max=512).

The actual leak is in the member initializer list of
MediaCodecVideoDecoder. This CL fixes the leak by adding a
ScopedLocalRefFrame outside of the ctor. All JNI code that originate
from a C++ thread (i.e. the entry point is not a Java thread) must use
a ScopedLocalRefFrame in order to avoid leaking local references.

BUG=webrtc:6969,b/36713034

Review-Url: https://codereview.webrtc.org/2780273002
Cr-Commit-Position: refs/heads/master@{#17464}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e4cd15d379b1a0bf1f91aaf87...
==========

[commit-bot: I haz the power, 2017-03-30 08:08:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e4cd15d379b1a0bf1f91aaf87...