Add logging around audio session interruptions

Add logging around audio session interruptions.
Always treat returning to foreground as interruption ended event, to help fix out of sync issues with interruption state.

BUG=0
Review-Url: https://codereview.webrtc.org/2780263002
Cr-Commit-Position: refs/heads/master@{#17457}
Committed: https://chromium.googlesource.com/external/webrtc/+/7735b1e932b439041238c1b68ae24d0529ba6828

[Chuck, 2017-03-29 19:40:32]

Description was changed from

==========
Add logging around audio session interruptions

BUG=0
==========

to

==========
Add logging around audio session interruptions.
Always treat returning to foreground as interruption ended event, to help fix
out of sync issues with interruption state.

BUG=0
==========

[Chuck, 2017-03-29 19:40:51]

haysc@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2017-03-29 20:02:51]

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/audio_device_ios.mm:487: RTCLog(@"Interruption
ended. IsInterrupted=%d. Updating audio unit state.",
nit: maybe for both these logs do
"Interruption changed from %d to %d."
(if the intent is to capture both old and new state)

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:89:
RTCLog(@"RTCAudioSession init: (%p)", self);
nit: "RTCAudioSession (%p): init"
(usually ptr value is shown first)

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:554: [self
notifyDidEndInterruptionWithShouldResumeSession:YES];
Hm. I don't recall the details here - but can you check that the audio device
doesn't freak out (ie doesn't try to reinit itself during a call) if we do this
each time app comes to foreground?

Also, can we add a way to distinguish between interruption ends that occur as a
result of app foregrounding, as opposed to when we're notified by OS? Right now
this one appears to be silent.

[Chuck, 2017-03-29 20:29:18]

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/audio_device_ios.mm:487: RTCLog(@"Interruption
ended. IsInterrupted=%d. Updating audio unit state.",
On 2017/03/29 20:02:51, tkchin_webrtc wrote:
> nit: maybe for both these logs do
> "Interruption changed from %d to %d."
> (if the intent is to capture both old and new state)

Done.

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm (right):

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:89:
RTCLog(@"RTCAudioSession init: (%p)", self);
On 2017/03/29 20:02:51, tkchin_webrtc wrote:
> nit: "RTCAudioSession (%p): init"
> (usually ptr value is shown first)

Done.

https://codereview.webrtc.org/2780263002/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm:554: [self
notifyDidEndInterruptionWithShouldResumeSession:YES];
On 2017/03/29 20:02:51, tkchin_webrtc wrote:
> Hm. I don't recall the details here - but can you check that the audio device
> doesn't freak out (ie doesn't try to reinit itself during a call) if we do
this
> each time app comes to foreground?
> 
> Also, can we add a way to distinguish between interruption ends that occur as
a
> result of app foregrounding, as opposed to when we're notified by OS? Right
now
> this one appears to be silent.

Modified the logging here so it always logs something.

It looks like this handles multiple end interrupts calls well. It checks the
state of the audio unit and only starts it if needed.

[tkchin_webrtc, 2017-03-29 21:18:13]

lgtm

[Chuck, 2017-03-29 21:25:42]

The CQ bit was checked by haysc@webrtc.org

[commit-bot: I haz the power, 2017-03-29 21:25:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 21:53:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490822742140760,
"parent_rev": "cf757cf3fd9a8b66ab555665a88e2a7f5d059c07", "commit_rev":
"7735b1e932b439041238c1b68ae24d0529ba6828"}

[commit-bot: I haz the power, 2017-03-29 21:53:36]

Description was changed from

==========
Add logging around audio session interruptions.
Always treat returning to foreground as interruption ended event, to help fix
out of sync issues with interruption state.

BUG=0
==========

to

==========
Add logging around audio session interruptions.
Always treat returning to foreground as interruption ended event, to help fix
out of sync issues with interruption state.

BUG=0

Review-Url: https://codereview.webrtc.org/2780263002
Cr-Commit-Position: refs/heads/master@{#17457}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7735b1e932b439041238c1b68...
==========

[commit-bot: I haz the power, 2017-03-29 21:53:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7735b1e932b439041238c1b68...