Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2780093002: ScreenCapturerWinDirectx may flicker on certain hardware (Closed)

Created:
3 years, 8 months ago by Hzj_jie
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ScreenCapturerWinDirectx may flicker on certain hardware Once the first capture attempt failed, we should keep the context->updated_region unchanged for next attempt. This change can (partially?) fix issue 704205. BUG=704205 Review-Url: https://codereview.webrtc.org/2780093002 Cr-Commit-Position: refs/heads/master@{#17456} Committed: https://chromium.googlesource.com/external/webrtc/+/cf757cf3fd9a8b66ab555665a88e2a7f5d059c07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Hzj_jie
3 years, 8 months ago (2017-03-29 03:47:30 UTC) #5
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-03-29 21:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2780093002/1
3 years, 8 months ago (2017-03-29 21:28:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cf757cf3fd9a8b66ab555665a88e2a7f5d059c07
3 years, 8 months ago (2017-03-29 21:37:58 UTC) #13
Sergey Ulanov
3 years, 8 months ago (2017-03-29 23:29:22 UTC) #14
Message was sent while issue was closed.
FWIW I can still reproduce the flickering issue on my machine. I'll try to
bisect to find what broke it.

Powered by Google App Engine
This is Rietveld 408576698