Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2779893002: Revert of Roll chromium_revision 581ff14023..8c40265f14 (459789:459958) (Closed)

Created:
3 years, 9 months ago by kjellander (google.com)
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 581ff14023..8c40265f14 (459789:459958) (patchset #1 id:1 of https://codereview.webrtc.org/2778123002/ ) Reason for revert: Breaks Linux 32 Release bot: https://build.chromium.org/p/client.webrtc/builders/Linux32%20Release/builds/11373 Original issue's description: > Roll chromium_revision 581ff14023..8c40265f14 (459789:459958) > > Change log: https://chromium.googlesource.com/chromium/src/+log/581ff14023..8c40265f14 > Full diff: https://chromium.googlesource.com/chromium/src/+/581ff14023..8c40265f14 > > Changed dependencies: > * src/base: https://chromium.googlesource.com/chromium/src/base/+log/52145f4993..3ad1bac16e > * src/build: https://chromium.googlesource.com/chromium/src/build/+log/55558c4eb0..9f91eb223d > * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f5f17bbe4d..a049c98cf2 > * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/554a1ebbe9..b17e7a51cc > * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/14e95b4f93..dc25a2f342 > * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0cfeabf700..ac3c19436e > * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/0ef14c1d4d..7e2f97c557 > DEPS diff: https://chromium.googlesource.com/chromium/src/+/581ff14023..8c40265f14/DEPS > > Clang version changed 296321:298539 > Details: https://chromium.googlesource.com/chromium/src/+/581ff14023..8c40265f14/tools/clang/scripts/update.py > > TBR= > BUG=None > > Review-Url: https://codereview.webrtc.org/2778123002 > Cr-Commit-Position: refs/heads/master@{#17404} > Committed: https://chromium.googlesource.com/external/webrtc/+/974c699d352783092a11f0f5639507749f2a8124 TBR=buildbot@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7413 Review-Url: https://codereview.webrtc.org/2779893002 Cr-Commit-Position: refs/heads/master@{#17406} Committed: https://chromium.googlesource.com/external/webrtc/+/fae2d2bdb3c4934cdab29eb160bdfc2d3c38d415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M DEPS View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander (google.com)
Created Revert of Roll chromium_revision 581ff14023..8c40265f14 (459789:459958)
3 years, 9 months ago (2017-03-28 04:34:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2779893002/1
3 years, 9 months ago (2017-03-28 04:35:03 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-28 04:35:05 UTC) #6
kjellander_webrtc
lgtm
3 years, 9 months ago (2017-03-28 04:36:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2779893002/1
3 years, 9 months ago (2017-03-28 04:36:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 04:36:52 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fae2d2bdb3c4934cdab29eb16...

Powered by Google App Engine
This is Rietveld 408576698