remove more CriticalSectionWrappers.

remove more CriticalSectionWrappers.

BUG=webrtc:7035
Review-Url: https://codereview.webrtc.org/2779623002
Cr-Commit-Position: refs/heads/master@{#17392}
Committed: https://chromium.googlesource.com/external/webrtc/+/d701dfdeef231185b262bc9fe7024b6211ae96bf

[kthelgason, 2017-03-27 11:11:10]

kthelgason@webrtc.org changed reviewers:
+ tommi@webrtc.org

[kthelgason, 2017-03-27 11:11:11]

I'm trying to keep these CLs manageble in size so I will split this work across
a few CLs.

[kthelgason, 2017-03-27 11:11:18]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 11:11:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 11:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 11:14:36]

Dry run: Try jobs failed on following builders:
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24228)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/20196)

[kthelgason, 2017-03-27 11:36:00]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 11:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-03-27 12:15:19]

lgtm with the 'const' qualifier below removed

https://codereview.webrtc.org/2779623002/diff/20001/webrtc/modules/audio_conf...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h
(right):

https://codereview.webrtc.org/2779623002/diff/20001/webrtc/modules/audio_conf...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h:151:
const rtc::CriticalSection _crit;
const? Even though Enter()/Leave() etc are const, I think it's a little
misleading to have the variable be const.  The reason for the methods being
const callable is so that the lock can be acquired from a const context without
having to mark the variable as |mutable|. The goal wasn't to support marking it
as const - that's more of a side effect.

[commit-bot: I haz the power, 2017-03-27 12:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 12:18:54]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2017-03-27 12:23:57]

https://codereview.webrtc.org/2779623002/diff/20001/webrtc/modules/audio_conf...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h
(right):

https://codereview.webrtc.org/2779623002/diff/20001/webrtc/modules/audio_conf...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h:151:
const rtc::CriticalSection _crit;
On 2017/03/27 12:15:19, tommi (webrtc) wrote:
> const? Even though Enter()/Leave() etc are const, I think it's a little
> misleading to have the variable be const.  The reason for the methods being
> const callable is so that the lock can be acquired from a const context
without
> having to mark the variable as |mutable|. The goal wasn't to support marking
it
> as const - that's more of a side effect.

Agree, done.

[kthelgason, 2017-03-27 12:24:14]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-03-27 12:24:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2779623002/#ps40001 (title:
"no const crit sections")

[commit-bot: I haz the power, 2017-03-27 12:24:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 12:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 12:25:55]

Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/18743)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24232)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/23046)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/24243)

[kthelgason, 2017-03-27 13:42:38]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-03-27 13:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2779623002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2017-03-27 13:42:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 14:24:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490622158040290,
"parent_rev": "1c07c70d88eca07888bf242921dc8dfc3be95737", "commit_rev":
"d701dfdeef231185b262bc9fe7024b6211ae96bf"}

[commit-bot: I haz the power, 2017-03-27 14:25:00]

Description was changed from

==========
remove more CriticalSectionWrappers.

BUG=webrtc:7035
==========

to

==========
remove more CriticalSectionWrappers.

BUG=webrtc:7035

Review-Url: https://codereview.webrtc.org/2779623002
Cr-Commit-Position: refs/heads/master@{#17392}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d701dfdeef231185b262bc9fe...
==========

[commit-bot: I haz the power, 2017-03-27 14:25:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/d701dfdeef231185b262bc9fe...