Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2777983004: iOS:Add loopback launch argument functionality in AppRTCMobile. (Closed)

Created:
3 years, 8 months ago by daniela-webrtc
Modified:
3 years, 8 months ago
Reviewers:
magjed_webrtc, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS:Add loopback launch argument functionality in AppRTCMobile. It will enable us to start immediate loopback just by passing the "loopback" string, as argument when launching. Usefull for testing and command line profiling. BUG=NONE Review-Url: https://codereview.webrtc.org/2777983004 Cr-Commit-Position: refs/heads/master@{#17426} Committed: https://chromium.googlesource.com/external/webrtc/+/5db450d244c7ec6e7e37a0ac71f11232b6bbe82b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use static const instead of hardcoded value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainView.m View 1 chunk +6 lines, -12 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m View 1 4 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
daniela-webrtc
Please take a look when you have time
3 years, 8 months ago (2017-03-28 08:59:20 UTC) #2
magjed_webrtc
lgtm
3 years, 8 months ago (2017-03-28 11:24:16 UTC) #3
sakal
lgtm https://codereview.webrtc.org/2777983004/diff/1/webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m File webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m (right): https://codereview.webrtc.org/2777983004/diff/1/webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m#newcode45 webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m:45: if ([[[NSProcessInfo processInfo] arguments] containsObject:@"loopback"]) { nit: Use ...
3 years, 8 months ago (2017-03-28 14:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2777983004/20001
3 years, 8 months ago (2017-03-28 15:02:00 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 15:27:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5db450d244c7ec6e7e37a0ac7...

Powered by Google App Engine
This is Rietveld 408576698