Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2777913002:
Reduce flakiness in EndToEnd probing tests. (Closed)
|
Created:
3 years, 9 months ago by philipel Modified:
3 years, 8 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman, kjellander_webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReduce flakiness in EndToEnd probing tests.
Reduce the flakiness by retrying up to 3 times.
BUG=webrtc:7403, webrtc:7419
Review-Url: https://codereview.webrtc.org/2777913002
Cr-Commit-Position: refs/heads/master@{#17473}
Committed: https://chromium.googlesource.com/external/webrtc/+/8a256525f13ebf322f3d539639fab79f13d17efa
Patch Set 1 #Patch Set 2 : Retry InitalProbing as well. #
Messages
Total messages: 24 (15 generated)
philipel@webrtc.org changed reviewers: + sprang@google.com
The CQ bit was checked by philipel@webrtc.org
The CQ bit was unchecked by philipel@webrtc.org
The CQ bit was checked by philipel@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reduce flakiness in EndToEndTest.TriggerMidCallProbing. Reduce the flakiness by retrying up to 3 times. BUG=webrtc:7403 ========== to ========== Reduce flakiness in EndToEnd probing tests. Reduce the flakiness by retrying up to 3 times. BUG=webrtc:7403, webrtc:7419 ==========
PTAL
sprang@webrtc.org changed reviewers: + sprang@webrtc.org
lgtm ... sort of... :/
The CQ bit was checked by philipel@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15602)
philipel@webrtc.org changed reviewers: + kjellander@webrtc.org
kjellander@, PTAL
lgtm
The CQ bit was checked by philipel@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490875381734720,
"parent_rev": "b13237b9dafd0ffbca64eba167d58a0dad410055", "commit_rev":
"8a256525f13ebf322f3d539639fab79f13d17efa"}
Message was sent while issue was closed.
Description was changed from ========== Reduce flakiness in EndToEnd probing tests. Reduce the flakiness by retrying up to 3 times. BUG=webrtc:7403, webrtc:7419 ========== to ========== Reduce flakiness in EndToEnd probing tests. Reduce the flakiness by retrying up to 3 times. BUG=webrtc:7403, webrtc:7419 Review-Url: https://codereview.webrtc.org/2777913002 Cr-Commit-Position: refs/heads/master@{#17473} Committed: https://chromium.googlesource.com/external/webrtc/+/8a256525f13ebf322f3d53963... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/8a256525f13ebf322f3d53963... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
