Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2777453003: Minor Cleanup of RTCAudioSource. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 8 months ago
Reviewers:
the sun, magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor Cleanup of RTCAudioSource. This CL fixes a comment that has the wrong format, and takes over ownership of an orphaned todo. It also removes some unneeded code from ObjC classes and moves them to a style more fitting the rest of the codebase. BUG=None Review-Url: https://codereview.webrtc.org/2777453003 Cr-Commit-Position: refs/heads/master@{#17416} Committed: https://chromium.googlesource.com/external/webrtc/+/5a4c68e9f33ef2ddafd78db7f0ddffdf2a5c3b01

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm View 2 chunks +1 line, -7 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
kthelgason
ptal :)
3 years, 9 months ago (2017-03-24 11:48:01 UTC) #4
the sun
LGTM, thanks!
3 years, 9 months ago (2017-03-24 13:13:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2777453003/20001
3 years, 9 months ago (2017-03-24 14:43:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15336)
3 years, 9 months ago (2017-03-24 14:48:00 UTC) #11
kthelgason
+magjed for OWNER approval
3 years, 8 months ago (2017-03-28 07:22:16 UTC) #13
magjed_webrtc
lgtm
3 years, 8 months ago (2017-03-28 08:31:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2777453003/20001
3 years, 8 months ago (2017-03-28 10:46:40 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 11:36:03 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5a4c68e9f33ef2ddafd78db7f...

Powered by Google App Engine
This is Rietveld 408576698