Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2776803002: Enable vp9 row-based multithreading. (Closed)

Created:
3 years, 9 months ago by jianj
Modified:
3 years, 8 months ago
Reviewers:
tommi, brandtr, marpan2, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. ~6% speedup on AppRTC on Linux/Mac with 4 threads. BUG=None Review-Url: https://codereview.webrtc.org/2776803002 Cr-Commit-Position: refs/heads/master@{#17432} Committed: https://chromium.googlesource.com/external/webrtc/+/cb5d1150dbf7b8de6094680437ff3c809b233161

Patch Set 1 #

Patch Set 2 : Enable vp9 row-based multithreading. #

Patch Set 3 : Change commit message, comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
jianj
3 years, 9 months ago (2017-03-27 23:17:51 UTC) #16
jianj
I've updated some numbers in the commit message per tommi's reqeust.
3 years, 8 months ago (2017-03-29 03:45:58 UTC) #18
mflodman
We'll also see the difference in the perf tests once submitted. LGTM
3 years, 8 months ago (2017-03-29 04:21:24 UTC) #19
tommi
lgtm Thanks!
3 years, 8 months ago (2017-03-29 06:31:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2776803002/40001
3 years, 8 months ago (2017-03-29 06:31:50 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 06:56:13 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cb5d1150dbf7b8de609468043...

Powered by Google App Engine
This is Rietveld 408576698