|
|
DescriptionEnable vp9 row-based multithreading.
Improves current multi-threading performance (for the same number of threads) by:
5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac
with standalone libvpx.
~6% speedup on AppRTC on Linux/Mac with 4 threads.
BUG=None
Review-Url: https://codereview.webrtc.org/2776803002
Cr-Commit-Position: refs/heads/master@{#17432}
Committed: https://chromium.googlesource.com/external/webrtc/+/cb5d1150dbf7b8de6094680437ff3c809b233161
Patch Set 1 #Patch Set 2 : Enable vp9 row-based multithreading. #Patch Set 3 : Change commit message, comments. #Messages
Total messages: 26 (20 generated)
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24188) mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/20157) mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/24198)
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable vp9 row-based multithreading. 8-10% speedup for ARM speed 8. 5%-8% speedup on Linux & Mac. BUG=None ========== to ========== Enable vp9 row-based multithreading. 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. BUG=None ==========
jianj@google.com changed reviewers: + brandtr@webrtc.org, marpan@webrtc.org, mflodman@webrtc.org
Description was changed from ========== Enable vp9 row-based multithreading. 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. BUG=None ========== to ========== Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. BUG=None ==========
The CQ bit was checked by jianj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. BUG=None ========== to ========== Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. ~6% speedup on AppRTC on Linux/Mac with 4 threads. BUG=None ==========
I've updated some numbers in the commit message per tommi's reqeust.
We'll also see the difference in the perf tests once submitted. LGTM
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
The CQ bit was checked by tommi@webrtc.org
lgtm Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490769102161510, "parent_rev": "acfb0177754cbf517a43dcae372e1672b141c3b9", "commit_rev": "cb5d1150dbf7b8de6094680437ff3c809b233161"}
Message was sent while issue was closed.
Description was changed from ========== Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. ~6% speedup on AppRTC on Linux/Mac with 4 threads. BUG=None ========== to ========== Enable vp9 row-based multithreading. Improves current multi-threading performance (for the same number of threads) by: 5%-8% speedup for 2 threads, ~15% for 4 threads on Linux/Mac with standalone libvpx. ~6% speedup on AppRTC on Linux/Mac with 4 threads. BUG=None Review-Url: https://codereview.webrtc.org/2776803002 Cr-Commit-Position: refs/heads/master@{#17432} Committed: https://chromium.googlesource.com/external/webrtc/+/cb5d1150dbf7b8de609468043... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/cb5d1150dbf7b8de609468043... |