Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2775613002:
Update clang-format to use Google style guide for ObjC. (Closed)
DescriptionUpdate clang-format to use Google style guide for ObjC.
We are using Google style guide for ObjC code. Clang-format now allows
us to differentiate between C++ and ObjC code. With this change it now
uses Google style guide with ColumnLimit of 100 for ObjC code.
NOTRY=True
BUG=webrtc:7406
Review-Url: https://codereview.webrtc.org/2775613002
Cr-Commit-Position: refs/heads/master@{#17387}
Committed: https://chromium.googlesource.com/external/webrtc/+/708f731fd18719b3c96c0536b6514fb2342aadf8
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
sakal@webrtc.org changed reviewers: + denicija@webrtc.org
PTAL
Description was changed from ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. ========== to ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True ==========
Description was changed from ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True ========== to ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True BUG=None ==========
Finally! Thank you Sami for submitting this. LGMT
On 2017/03/23 14:35:29, daniela-webrtc wrote: > Finally! Thank you Sami for submitting this. > LGMT LGTM =)
sakal@webrtc.org changed reviewers: + mflodman@webrtc.org
Flodman, could you stamp this please?
LGTM
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True BUG=None ========== to ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True BUG=webrtc:7406 ==========
The CQ bit was unchecked by sakal@webrtc.org
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490614431672010, "parent_rev":
"1ccf73f830fd3f4ca75b0e4fd15adc784991edaa", "commit_rev":
"708f731fd18719b3c96c0536b6514fb2342aadf8"}
Message was sent while issue was closed.
Description was changed from ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True BUG=webrtc:7406 ========== to ========== Update clang-format to use Google style guide for ObjC. We are using Google style guide for ObjC code. Clang-format now allows us to differentiate between C++ and ObjC code. With this change it now uses Google style guide with ColumnLimit of 100 for ObjC code. NOTRY=True BUG=webrtc:7406 Review-Url: https://codereview.webrtc.org/2775613002 Cr-Commit-Position: refs/heads/master@{#17387} Committed: https://chromium.googlesource.com/external/webrtc/+/708f731fd18719b3c96c0536b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/708f731fd18719b3c96c0536b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
