Let PacketRouter separate send and receive modules.

webrtc/modules/pacing/packet_router.h

Index: webrtc/modules/pacing/packet_router.h
diff --git a/webrtc/modules/pacing/packet_router.h b/webrtc/modules/pacing/packet_router.h
index 0dc3fb53bad6ea3fb2369a981819a1c2ee708814..a3de042fdb17849acc6d6353c2f8582ebd8edb34 100644
--- a/webrtc/modules/pacing/packet_router.h
+++ b/webrtc/modules/pacing/packet_router.h
@@ -36,8 +36,18 @@ class PacketRouter : public PacedSender::PacketSender,
   PacketRouter();
   virtual ~PacketRouter();
 
-  void AddRtpModule(RtpRtcp* rtp_module);
-  void RemoveRtpModule(RtpRtcp* rtp_module);
+  // TODO(nisse): Delete, as soon as downstream app is updated.
+  RTC_DEPRECATED void AddRtpModule(RtpRtcp* rtp_module) {
+    AddReceiveRtpModule(rtp_module);
+  }
+  RTC_DEPRECATED void RemoveRtpModule(RtpRtcp* rtp_module) {
+    RemoveReceiveRtpModule(rtp_module);
+  }
+  void AddSendRtpModule(RtpRtcp* rtp_module);
+  void RemoveSendRtpModule(RtpRtcp* rtp_module);
+
+  void AddReceiveRtpModule(RtpRtcp* rtp_module);
+  void RemoveReceiveRtpModule(RtpRtcp* rtp_module);
 
   // Implements PacedSender::Callback.
   bool TimeToSendPacket(uint32_t ssrc,
@@ -58,7 +68,8 @@ class PacketRouter : public PacedSender::PacketSender,
  private:
   rtc::ThreadChecker pacer_thread_checker_;
   rtc::CriticalSection modules_crit_;
-  std::list<RtpRtcp*> rtp_modules_ GUARDED_BY(modules_crit_);
+  std::list<RtpRtcp*> rtp_send_modules_ GUARDED_BY(modules_crit_);
+  std::list<RtpRtcp*> rtp_receive_modules_ GUARDED_BY(modules_crit_);

[the sun, 2017/03/28 12:21:52]

Any particular reason to use std::list? More cache jumping when iterating over,
vs vector.

[nisse-webrtc, 2017/03/29 13:58:37]

For the list of send modules, the code uses both push_back and push_front. The
list of receive modules could be changed to vector.

 
   volatile int transport_seq_;