Let PacketRouter separate send and receive modules.

webrtc/modules/pacing/packet_router.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 18 matching lines @@
 }  // namespace rtcp
 
 // PacketRouter routes outgoing data to the correct sending RTP module, based
 // on the simulcast layer in RTPVideoHeader.
 class PacketRouter : public PacedSender::PacketSender,
                      public TransportSequenceNumberAllocator {
  public:
   PacketRouter();
   virtual ~PacketRouter();
 
-  void AddRtpModule(RtpRtcp* rtp_module);
-  void RemoveRtpModule(RtpRtcp* rtp_module);
+  // TODO(nisse): Delete, as soon as downstream app is updated.
+  RTC_DEPRECATED void AddRtpModule(RtpRtcp* rtp_module) {
+    AddReceiveRtpModule(rtp_module);
+  }
+  RTC_DEPRECATED void RemoveRtpModule(RtpRtcp* rtp_module) {
+    RemoveReceiveRtpModule(rtp_module);
+  }
+  void AddSendRtpModule(RtpRtcp* rtp_module);
+  void RemoveSendRtpModule(RtpRtcp* rtp_module);
+
+  void AddReceiveRtpModule(RtpRtcp* rtp_module);
+  void RemoveReceiveRtpModule(RtpRtcp* rtp_module);
 
   // Implements PacedSender::Callback.
   bool TimeToSendPacket(uint32_t ssrc,
                         uint16_t sequence_number,
                         int64_t capture_timestamp,
                         bool retransmission,
                         const PacedPacketInfo& packet_info) override;
 
   size_t TimeToSendPadding(size_t bytes,
                            const PacedPacketInfo& packet_info) override;
 
   void SetTransportWideSequenceNumber(uint16_t sequence_number);
   uint16_t AllocateSequenceNumber() override;
 
   // Send transport feedback packet to send-side.
   virtual bool SendFeedback(rtcp::TransportFeedback* packet);
 
  private:
   rtc::ThreadChecker pacer_thread_checker_;
   rtc::CriticalSection modules_crit_;
-  std::list<RtpRtcp*> rtp_modules_ GUARDED_BY(modules_crit_);
+  std::list<RtpRtcp*> rtp_send_modules_ GUARDED_BY(modules_crit_);
+  std::list<RtpRtcp*> rtp_receive_modules_ GUARDED_BY(modules_crit_);

[the sun, 2017/03/28 12:21:52]

Any particular reason to use std::list? More cache jumping when iterating over,
vs vector.

[nisse-webrtc, 2017/03/29 13:58:37]

For the list of send modules, the code uses both push_back and push_front. The
list of receive modules could be changed to vector.

 
   volatile int transport_seq_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(PacketRouter);
 };
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_PACING_PACKET_ROUTER_H_