Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2772993002: Remove the final methods from FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the final methods from FrameHost BUG=688614 Review-Url: https://codereview.chromium.org/2772993002 Cr-Commit-Position: refs/heads/master@{#459976} Committed: https://chromium.googlesource.com/chromium/src/+/9a9f07ea8b25f4f4165687334b6e585357a93a38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 2 chunks +0 lines, -19 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
sashab
3 years, 9 months ago (2017-03-24 00:06:56 UTC) #3
slangley
lgtm
3 years, 9 months ago (2017-03-24 00:25:56 UTC) #5
sashab
haraken ptal
3 years, 9 months ago (2017-03-24 00:29:22 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-24 00:35:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772993002/1
3 years, 8 months ago (2017-03-28 00:19:47 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 01:50:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a9f07ea8b25f4f4165687334b6e...

Powered by Google App Engine
This is Rietveld 408576698