Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2772043002: Revert of WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType (Closed)

Created:
3 years, 9 months ago by kwiberg-webrtc
Modified:
3 years, 9 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType (patchset #13 id:260001 of https://codereview.webrtc.org/2686043006/ ) Reason for revert: Makes perf and Chromium FYI bots unhappy. Original issue's description: > WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType > > This removes one more place where we were unable to handle codecs not > in the built-in set. > > BUG=webrtc:5805 > > Review-Url: https://codereview.webrtc.org/2686043006 > Cr-Commit-Position: refs/heads/master@{#17370} > Committed: https://chromium.googlesource.com/external/webrtc/+/1724cfbdbafef4736fedda37312b0286f1eb03d0 TBR=ossu@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5805 Review-Url: https://codereview.webrtc.org/2772043002 Cr-Commit-Position: refs/heads/master@{#17374} Committed: https://chromium.googlesource.com/external/webrtc/+/670a7f3611243bf7df5f82d91e8ead2e9951b51c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -222 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/call/call_unittest.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 5 chunks +40 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 7 chunks +77 lines, -34 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 4 chunks +23 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.cc View 5 chunks +0 lines, -14 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/codec_before_streaming_test.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kwiberg-webrtc
Created Revert of WebRtcVoiceMediaChannel::AddRecvStream: Don't call SetRecPayloadType
3 years, 9 months ago (2017-03-24 12:56:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2772043002/1
3 years, 9 months ago (2017-03-24 12:56:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/670a7f3611243bf7df5f82d91e8ead2e9951b51c
3 years, 9 months ago (2017-03-24 12:56:26 UTC) #6
the sun
3 years, 9 months ago (2017-03-24 13:19:05 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698