Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2771573002:
Use constexpr function FourCC instead of macro (Closed)
|
Created:
3 years, 9 months ago by Hzj_jie Modified:
3 years, 9 months ago Reviewers:
Sergey Ulanov CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUse constexpr function FourCC instead of macro
constexpr function should be preferred than a macro. So this change replaces
FOURCC() macro with a constexpr uint32_t FourCC() function.
BUG=679523, 650926
Review-Url: https://codereview.webrtc.org/2771573002
Cr-Commit-Position: refs/heads/master@{#17351}
Committed: https://chromium.googlesource.com/external/webrtc/+/65cb53a5c670d3aa1091f1fabf1d8b443e331296
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use constexpr function FourCC instead of macro constexpr function should be preferred than a macro. So this change replaces FOURCC() macro with a constexpr uint32_t FourCC() function. BUG=679523, 650926 ========== to ========== Use constexpr function FourCC instead of macro constexpr function should be preferred than a macro. So this change replaces FOURCC() macro with a constexpr uint32_t FourCC() function. BUG=679523, 650926 ==========
zijiehe@chromium.org changed reviewers: + sergeyu@chromium.org
lgtm when my comment is addressed https://codereview.webrtc.org/2771573002/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/desktop_capture_types.h (right): https://codereview.webrtc.org/2771573002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/desktop_capture_types.h:39: constexpr uint32_t FourCC(char a, char b, char c, char d) { This is a still quite generic name, and it can easily cause conflicts in the future. Call it GetDesktopCaptureIdFourCC()?
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2771573002/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/desktop_capture_types.h (right): https://codereview.webrtc.org/2771573002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/desktop_capture_types.h:39: constexpr uint32_t FourCC(char a, char b, char c, char d) { On 2017/03/22 21:05:21, Sergey Ulanov wrote: > This is a still quite generic name, and it can easily cause conflicts in the > future. Call it GetDesktopCaptureIdFourCC()? I moved it to DesktopCapturerId namespace, and rename it to CreateFourCC().
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/19931)
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.webrtc.org/2771573002/#ps20001 (title: "Resolve review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490220516193380,
"parent_rev": "b84701931f499d15680c1016f386fc7d8ade55bb", "commit_rev":
"65cb53a5c670d3aa1091f1fabf1d8b443e331296"}
Message was sent while issue was closed.
Description was changed from ========== Use constexpr function FourCC instead of macro constexpr function should be preferred than a macro. So this change replaces FOURCC() macro with a constexpr uint32_t FourCC() function. BUG=679523, 650926 ========== to ========== Use constexpr function FourCC instead of macro constexpr function should be preferred than a macro. So this change replaces FOURCC() macro with a constexpr uint32_t FourCC() function. BUG=679523, 650926 Review-Url: https://codereview.webrtc.org/2771573002 Cr-Commit-Position: refs/heads/master@{#17351} Committed: https://chromium.googlesource.com/external/webrtc/+/65cb53a5c670d3aa1091f1fab... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/65cb53a5c670d3aa1091f1fab...
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
