 Chromium Code Reviews
 Chromium Code Reviews Issue 2770113004:
  Pass settings model to ARDAppClient instead of individual settings.  (Closed)
    
  
    Issue 2770113004:
  Pass settings model to ARDAppClient instead of individual settings.  (Closed) 
  | Index: webrtc/examples/objc/AppRTCMobile/ARDAppClient.h | 
| diff --git a/webrtc/examples/objc/AppRTCMobile/ARDAppClient.h b/webrtc/examples/objc/AppRTCMobile/ARDAppClient.h | 
| index 0feb01586aab2a0760267f591c3012d6a477886b..eed643866cabed8d42a913480533f8bf9b3ad1c1 100644 | 
| --- a/webrtc/examples/objc/AppRTCMobile/ARDAppClient.h | 
| +++ b/webrtc/examples/objc/AppRTCMobile/ARDAppClient.h | 
| @@ -13,6 +13,8 @@ | 
| #import "WebRTC/RTCPeerConnection.h" | 
| #import "WebRTC/RTCVideoTrack.h" | 
| +#import "ARDSettingsModel.h" | 
| + | 
| 
daniela-webrtc
2017/03/26 15:49:49
Usually in header files (.h)
@class ARDSettingsMo
 
sakal
2017/03/27 13:34:24
Done.
 | 
| typedef NS_ENUM(NSInteger, ARDAppClientState) { | 
| // Disconnected from servers. | 
| kARDAppClientStateDisconnected, | 
| @@ -60,14 +62,7 @@ typedef NS_ENUM(NSInteger, ARDAppClientState) { | 
| @property(nonatomic, weak) id<ARDAppClientDelegate> delegate; | 
| // Convenience constructor since all expected use cases will need a delegate | 
| // in order to receive remote tracks. | 
| -- (instancetype)initWithDelegate:(id<ARDAppClientDelegate>)delegate | 
| - preferVideoCodec:(NSString*)codec; | 
| - | 
| -// Sets camera constraints. | 
| -- (void)setCameraConstraints:(RTCMediaConstraints *)mediaConstraints; | 
| - | 
| -// Sets maximum bitrate the rtp sender should use. | 
| -- (void)setMaxBitrate:(NSNumber *)maxBitrate; | 
| +- (instancetype)initWithDelegate:(id<ARDAppClientDelegate>)delegate; | 
| // Establishes a connection with the AppRTC servers for the given room id. | 
| // If |isLoopback| is true, the call will connect to itself. | 
| @@ -76,6 +71,7 @@ typedef NS_ENUM(NSInteger, ARDAppClientState) { | 
| // If |shouldUseLevelControl| is true, the level controller will be used | 
| // in the call. | 
| - (void)connectToRoomWithId:(NSString *)roomId | 
| + usingSettings:(ARDSettingsModel *)settings | 
| 
daniela-webrtc
2017/03/26 15:49:49
Document this parameter as well.
 
sakal
2017/03/27 13:34:24
Done.
 | 
| isLoopback:(BOOL)isLoopback | 
| isAudioOnly:(BOOL)isAudioOnly | 
| shouldMakeAecDump:(BOOL)shouldMakeAecDump |