Pass settings model to ARDAppClient instead of individual settings.

webrtc/examples/objc/AppRTCMobile/ARDAppClient.h

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #import <Foundation/Foundation.h>
 
 #import "WebRTC/RTCPeerConnection.h"
 #import "WebRTC/RTCVideoTrack.h"
 
+#import "ARDSettingsModel.h"
+

[daniela-webrtc, 2017/03/26 15:49:49]

Usually in header files (.h)

@class ARDSettingsModel 

and import in implementation files (.m/mm)

[sakal, 2017/03/27 13:34:24]

Done.

 typedef NS_ENUM(NSInteger, ARDAppClientState) {
   // Disconnected from servers.
   kARDAppClientStateDisconnected,
   // Connecting to servers.
   kARDAppClientStateConnecting,
   // Connected to servers.
   kARDAppClientStateConnected,
 };
 
 @class ARDAppClient;
@@ skipping 27 matching lines @@
 // class should only be called from the main queue.
 @interface ARDAppClient : NSObject
 
 // If |shouldGetStats| is true, stats will be reported in 1s intervals through
 // the delegate.
 @property(nonatomic, assign) BOOL shouldGetStats;
 @property(nonatomic, readonly) ARDAppClientState state;
 @property(nonatomic, weak) id<ARDAppClientDelegate> delegate;
 // Convenience constructor since all expected use cases will need a delegate
 // in order to receive remote tracks.
-- (instancetype)initWithDelegate:(id<ARDAppClientDelegate>)delegate
-                preferVideoCodec:(NSString*)codec;
-
-// Sets camera constraints.
-- (void)setCameraConstraints:(RTCMediaConstraints *)mediaConstraints;
-
-// Sets maximum bitrate the rtp sender should use.
-- (void)setMaxBitrate:(NSNumber *)maxBitrate;
+- (instancetype)initWithDelegate:(id<ARDAppClientDelegate>)delegate;
 
 // Establishes a connection with the AppRTC servers for the given room id.
 // If |isLoopback| is true, the call will connect to itself.
 // If |isAudioOnly| is true, video will be disabled for the call.
 // If |shouldMakeAecDump| is true, an aecdump will be created for the call.
 // If |shouldUseLevelControl| is true, the level controller will be used
 // in the call.
 - (void)connectToRoomWithId:(NSString *)roomId
+              usingSettings:(ARDSettingsModel *)settings

[daniela-webrtc, 2017/03/26 15:49:49]

Document this parameter as well.

[sakal, 2017/03/27 13:34:24]

Done.

                  isLoopback:(BOOL)isLoopback
                 isAudioOnly:(BOOL)isAudioOnly
           shouldMakeAecDump:(BOOL)shouldMakeAecDump
       shouldUseLevelControl:(BOOL)shouldUseLevelControl;
 
 // Disconnects from the AppRTC servers and any connected clients.
 - (void)disconnect;
 
 @end