Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2769963003: Clear PacketBuffer when full. (Closed)

Created:
3 years, 9 months ago by philipel
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clear PacketBuffer when full. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2769963003 Cr-Commit-Position: refs/heads/master@{#17362} Committed: https://chromium.googlesource.com/external/webrtc/+/c703dc21a66a431837dac3f46372f47657fe7f1d

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M webrtc/modules/video_coding/packet_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
philipel
3 years, 9 months ago (2017-03-23 12:41:37 UTC) #2
philipel
PTAL
3 years, 9 months ago (2017-03-23 12:42:24 UTC) #3
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-23 12:44:20 UTC) #4
stefan-webrtc
Maybe add a unittest
3 years, 9 months ago (2017-03-23 12:44:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2769963003/20001
3 years, 9 months ago (2017-03-23 13:15:34 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 13:50:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c703dc21a66a431837dac3f46...

Powered by Google App Engine
This is Rietveld 408576698