Base screenshare layers on TemporalReferences.

Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@google.com, sprang@webrtc.org, marpan@webrtc.org

Review-Url: https://codereview.webrtc.org/2769263002 .
Cr-Commit-Position: refs/heads/master@{#17397}
Committed: https://chromium.googlesource.com/external/webrtc/+/1436c83cd11f636b49eacdbada2e7f6d17eb6d62

[pbos-webrtc, 2017-03-23 18:48:27]

PTAL

[pbos-webrtc, 2017-03-23 18:48:43]

Description was changed from

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders).

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@webrtc.org
==========

to

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@webrtc.org
==========

[pbos-webrtc, 2017-03-23 18:48:53]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 18:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-23 19:35:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:35:48]

Dry run: This issue passed the CQ dry run.

[pbos-webrtc, 2017-03-23 19:42:34]

Description was changed from

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@webrtc.org
==========

to

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@webrtc.org, sprang@webrtc.org
==========

[pbos-webrtc, 2017-03-23 19:42:34]

pbos@webrtc.org changed reviewers:
+ sprang@webrtc.org

[pbos-webrtc, 2017-03-23 19:42:46]

sprang@, ptal too

[sprang_webrtc, 2017-03-26 12:20:08]

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc (right):

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc:250: //
TODO(pbos): Name method so that it's obvious that it updates state.
Not sure "get" makes it obvious state is changed either. Maybe
UpdateLayerConfig() or NextLayerConfig() or something along those lines?

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:51: const bool
update_arf;
Would it make sense to only store TemporalBufferUsage instead, and have getter
methods for these if the convenience is worth it? Feel like we have some
unnecessary redundancy in the flags are represented.

[pbos-webrtc, 2017-03-27 16:31:07]

PTAL

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc (right):

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc:250: //
TODO(pbos): Name method so that it's obvious that it updates state.
On 2017/03/26 12:20:08, språng wrote:
> Not sure "get" makes it obvious state is changed either. Maybe
> UpdateLayerConfig() or NextLayerConfig() or something along those lines?

I like update. Thanks.

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2769263002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:51: const bool
update_arf;
On 2017/03/26 12:20:08, språng wrote:
> Would it make sense to only store TemporalBufferUsage instead, and have getter
> methods for these if the convenience is worth it? Feel like we have some
> unnecessary redundancy in the flags are represented.

Yes, since they can be checked as a bitmask we have the same thing. Done.

[pbos-webrtc, 2017-03-27 16:31:23]

feedback

[sprang_webrtc, 2017-03-27 16:38:19]

lgtm 
Thanks!

[marpan, 2017-03-27 17:42:07]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2017-03-27 17:42:08]

lgtm

[pbos-webrtc, 2017-03-27 19:01:52]

Description was changed from

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@webrtc.org, sprang@webrtc.org
==========

to

==========
Base screenshare layers on TemporalReferences.

Decouples encode flags and calculates them the same for both default and
screencast temporal layers.

With this change encoders could start using TemporalReferences for
temporal-layers flags, but they can not be used by asynchronous encoders
(hardware encoders) yet.

Also removes 'timestamp' as a dead parameter to FrameEncoded().

BUG=chromium:702017, webrtc:7349
R=marpan@google.com, sprang@webrtc.org, marpan@webrtc.org

Review-Url: https://codereview.webrtc.org/2769263002 .
Cr-Commit-Position: refs/heads/master@{#17397}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1436c83cd11f636b49eacdbad...
==========

[pbos-webrtc, 2017-03-27 19:01:53]

Committed patchset #2 (id:20001) manually as
1436c83cd11f636b49eacdbada2e7f6d17eb6d62 (presubmit successful).